-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial Littany of Safety Enhancements #122
Merged
Merged
Commits on Sep 10, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 369a2cd - Browse repository at this point
Copy the full SHA 369a2cdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6dbe8e3 - Browse repository at this point
Copy the full SHA 6dbe8e3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6546060 - Browse repository at this point
Copy the full SHA 6546060View commit details -
Configuration menu - View commit details
-
Copy full SHA for a4e7480 - Browse repository at this point
Copy the full SHA a4e7480View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6496028 - Browse repository at this point
Copy the full SHA 6496028View commit details -
Configuration menu - View commit details
-
Copy full SHA for b8fcf51 - Browse repository at this point
Copy the full SHA b8fcf51View commit details -
Remove most unsafety in big int.
The safety guarantees that aren't validated immediately have been removed (so only keeping the unsafe code in the hi bit extraction, which is checked right in the call), and this leads to ~3% degradation in performance in the worst cases, which is still 90% faster than core so it's well worth it. The unsafe code in the multiplication algorithms is the cause of the slowdown, but well worth it.
Configuration menu - View commit details
-
Copy full SHA for 7f634f9 - Browse repository at this point
Copy the full SHA 7f634f9View commit details -
Remove length then unsafe index with get(0).
Seems to improve performance on some edge case floats invoking this path by up to 30%.
Configuration menu - View commit details
-
Copy full SHA for 862d5df - Browse repository at this point
Copy the full SHA 862d5dfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 62d3c21 - Browse repository at this point
Copy the full SHA 62d3c21View commit details
Commits on Sep 11, 2024
-
Remove unnecessary unsafe checks and fix a few minor format bugs.
Introduce a self-contained `Buffer` trait that allows simpler comparison of values, and then remove more unsafety, especially in cases where the compiler can trivially provide the unsafety is sound. Then, also fix a minor bug with formatting where the mantissa radix negative sign check was used and not the exponent one.
Configuration menu - View commit details
-
Copy full SHA for 8a7639c - Browse repository at this point
Copy the full SHA 8a7639cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 13194a5 - Browse repository at this point
Copy the full SHA 13194a5View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.