Initial Littany of Safety Enhancements #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The safety guarantees that aren't validated immediately have been removed (so only keeping the unsafe code in the hi bit extraction, which is checked right in the call), and this leads to ~3% degradation in performance in the worst cases, which is still 90% faster than core so it's well worth it. The unsafe code in the multiplication algorithms is the cause of the slowdown, but well worth it.
Seems to improve performance on some edge case floats invoking this path by up to 30%.
Introduce a self-contained `Buffer` trait that allows simpler comparison of values, and then remove more unsafety, especially in cases where the compiler can trivially provide the unsafety is sound. Then, also fix a minor bug with formatting where the mantissa radix negative sign check was used and not the exponent one.
Alexhuszagh
added
high priority
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes a lot of unsafe code, documents the cases where removing it would have significant performance impacts but the safety invariants can be easily guaranteed, and likewise makes other enhancements to remove potentially unsafe behavior. This also redoes some architecture to make more code wrapped into safe variants, where rather than say
if x.get(0) == b'0'. then do an unchecked index, instead it just has a peek and step in a single function, where applicable.. This also simplifies the code base a lot.Part of many commits to address #100.