Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flake: fix overlay not actually being applied #3208

Merged
merged 1 commit into from
May 6, 2024

Conversation

spitulax
Copy link
Contributor

@spitulax spitulax commented May 4, 2024

#3196 made some changes to flake.nix. In this line flake's waybar package was defined to be the one in nixpkgs because the function that was passed to genSystems argument was called with nixpkgs without the flake's overlay applied. I changed the genSystems function to pass nixpkgs that uses the flake's overlay so the package comes from the flake itself and not nixpkgs.

@spikespaz
Copy link
Contributor

Thanks, apologies to @Arjun31415 and others.

This PR is crucial to merge (I was almost about to PR), because I made a mistake (again!) and this commit is borked.

@Alexays Alexays merged commit c4e0c56 into Alexays:master May 6, 2024
@spitulax spitulax deleted the fix-overlay branch May 6, 2024 13:27
zjeffer pushed a commit to zjeffer/Waybar that referenced this pull request May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants