Nix Flake: Fix overlay (again) #3196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
My last PR fixed the issue that `callPackage` was being used from `prev`, which would mean that all of the arguments it passes to the expression are also going to be from `prev`. This would have been wrong, so I fixed it to get dependencies from `final`, except that I missed `waybar` which does need to come from `prev`.
|
Thanks! |
|
Umm, I think it broke for me. waybar = {
url = "github:Alexays/Waybar";
inputs.nixpkgs.follows = "nixpkgs";
};This is how I was using it programs.waybar = {
enable = true;
package = inputs.waybar.packages.${pkgs.system}.default;
systemd.enable = false;
};This is the flake.lock relevant section "waybar": {
"inputs": {
"flake-compat": "flake-compat_7",
"nixpkgs": [
"nixpkgs"
]
},
"locked": {
"lastModified": 1714718861,
"narHash": "sha256-mCQdrn0Y3oOVZP/CileWAhuBX6aARBNrfxyqJBB4NxA=",
"owner": "Alexays",
"repo": "Waybar",
"rev": "231d6972d7a023e9358ab7deda509baac49006cb",
"type": "github"
},
"original": {
"owner": "Alexays",
"repo": "Waybar",
"type": "github"
}
},But And so the bar is broken as I am on hyprland and the socket path has changed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because last time I "fixed" it, I actually broke it, I forgot a line, but this time I changed other minor stuff (added
waybar-named overlay and package, in addition todefault, and the package output now is properly inherited from the overlay applied on top of Nixpkgs).