Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.3-stable] fix new page form #3064

Merged
merged 1 commit into from
Oct 4, 2024
Merged

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Oct 4, 2024

Backport

This will backport the following commits from main to 7.3-stable:

Questions ?

Please refer to the Backport tool documentation

validation on urlname needs to be on name becuase name is the input and by type we need to change nil in selected page layout

(cherry picked from commit ffa5e2d)
@tvdeyen tvdeyen requested a review from a team as a code owner October 4, 2024 14:25
@tvdeyen tvdeyen mentioned this pull request Oct 4, 2024
3 tasks
Copy link

codecov bot commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.47%. Comparing base (4b13666) to head (dc11e58).
Report is 4 commits behind head on 7.3-stable.

Additional details and impacted files
@@             Coverage Diff             @@
##           7.3-stable    #3064   +/-   ##
===========================================
  Coverage       96.47%   96.47%           
===========================================
  Files             237      237           
  Lines            6407     6408    +1     
===========================================
+ Hits             6181     6182    +1     
  Misses            226      226           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tvdeyen tvdeyen merged commit af895f9 into 7.3-stable Oct 4, 2024
38 checks passed
@tvdeyen tvdeyen deleted the backport/7.3-stable/pr-3060 branch October 4, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants