Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix new page form #3060

Merged
merged 1 commit into from
Oct 4, 2024
Merged

fix new page form #3060

merged 1 commit into from
Oct 4, 2024

Conversation

zp1984
Copy link
Contributor

@zp1984 zp1984 commented Oct 2, 2024

What is this pull request for?

validation on urlname needs to be on name becuase name is the input and by type we need to change nil in selected page layout

Describe you pull request here...

Checklist

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have added tests to cover this change

Copy link

codecov bot commented Oct 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.63%. Comparing base (4c20717) to head (ffa5e2d).
Report is 22 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3060      +/-   ##
==========================================
- Coverage   96.63%   96.63%   -0.01%     
==========================================
  Files         236      235       -1     
  Lines        6331     6324       -7     
==========================================
- Hits         6118     6111       -7     
  Misses        213      213              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zp1984 zp1984 marked this pull request as ready for review October 4, 2024 06:48
@zp1984 zp1984 requested a review from a team as a code owner October 4, 2024 06:48
validation on urlname needs to be on name becuase name is the input and by type we need to change nil in selected page layout
@tvdeyen tvdeyen added the backport-to-7.3-stable Needs to be backported to 7.3-stable label Oct 4, 2024
Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@tvdeyen tvdeyen merged commit 88075e2 into AlchemyCMS:main Oct 4, 2024
40 checks passed
@tvdeyen
Copy link
Member

tvdeyen commented Oct 4, 2024

💚 All backports created successfully

Status Branch Result
7.3-stable

Questions ?

Please refer to the Backport tool documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-to-7.3-stable Needs to be backported to 7.3-stable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants