Sortable menus #1758
Merged
Sortable menus #1758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
tvdeyen
requested changes
Mar 22, 2020
mamhoff
force-pushed
the
sortable-menus
branch
2 times, most recently
from
c5d93f4 to
71e949b
Compare
Closed
tvdeyen
approved these changes
Mar 22, 2020
This is the simplest serializer for a node.
This moves an node to a specified parent and a specified position.
This is a nice sorting library that works with trees.
tvdeyen
reviewed
Mar 23, 2020
tvdeyen
requested changes
Mar 23, 2020
tvdeyen
requested changes
Mar 25, 2020
This commit allows sorting of menus. We instantiate for each element in the tree one instance of Sortable.js, but - through the `group` option - allow dragging and dropping between each element. For this to work, all `ul` elements need to be present (otherwise we cannot drop a node below a list that does not have nodes yet). A little tricky was the correct behaviour of the `folded` button: It should only be displayed if there are any pages to fold. This is now accomplished through rendering the `+` and `-` buttons in Javascript, depending on how many elements are in each list after sorting. Additionally: The full node tree is now rendered on page load, and all manipulations manipulate the DOM. There are no nodes being inserted or deleted through sorting or folding.
I had to reimplement jQuery.on for this to work.
We'll need to use this elsewhere.
Now it also returns a bit of JSON about the toggled node.
To make the dragging functionality more obvious.
tvdeyen
approved these changes
Mar 25, 2020
tvdeyen
added a commit
that referenced
this pull request
Mar 30, 2020
- Sortable menus [#1758](#1758) ([mamhoff](https://github.com/mamhoff)) - Programmatic menus [#1756](#1756) ([mamhoff](https://github.com/mamhoff)) - Fix syntax in non-erb Menu templates [#1751]((#1751)) ([Alexander ADAM](https://github.com/alexanderadam)) - Fix `render_menu` for custom controllers [#1746]((#1746)) ([Alexander ADAM](https://github.com/alexanderadam))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
Allows sorting of menus :)
Notable changes (remove if none)
Adds a dependency to Sortable.js. I THINK this might actually work for the page tree as well, and the chosen solution is probably way faster than the solution chosen for the page tree. We only update one element, really.
Screenshots
Checklist