Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: fix syntax in non-erb templates #1751

Merged
merged 1 commit into from
Mar 18, 2020
Merged

bugfix: fix syntax in non-erb templates #1751

merged 1 commit into from
Mar 18, 2020

Conversation

alexanderadam
Copy link
Contributor

@alexanderadam alexanderadam commented Mar 18, 2020

What is this pull request for?

it fixes the syntax in non-erb templates

Checklist

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have added tests to cover this change — no, the correct way would be to add haml-lint and add it to the CI pipeline. It also integrates with RuboCop.

Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ups. Thanks

@tvdeyen tvdeyen merged commit af1744c into AlchemyCMS:master Mar 18, 2020
@alexanderadam alexanderadam deleted the bugfix/fix-non-erb-templates-syntax branch March 18, 2020 14:41
tvdeyen pushed a commit that referenced this pull request Mar 30, 2020
tvdeyen added a commit that referenced this pull request Mar 30, 2020
- Sortable menus [#1758](#1758) ([mamhoff](https://github.com/mamhoff))
- Programmatic menus [#1756](#1756) ([mamhoff](https://github.com/mamhoff))
- Fix syntax in non-erb Menu templates [#1751]((#1751)) ([Alexander ADAM](https://github.com/alexanderadam))
- Fix `render_menu` for custom controllers [#1746]((#1746)) ([Alexander ADAM](https://github.com/alexanderadam))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants