Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid query throws n.Term #1871 #1903

Merged
merged 1 commit into from
Mar 18, 2024
Merged

Conversation

vishal6557
Copy link
Contributor

Fix #1871

Thank you for the time you are putting into AlaSQL!

@vishal6557
Copy link
Contributor Author

@mathiasrw Have a look, any feedback is appreciated!

@mathiasrw
Copy link
Member

Very interesting how you solved this. Im wondering why the yy.Term was there in the first place.

Ill merge it.

Did you have any problem generating the file from the jison? I had some challenges with deep dependencies lately. Or did you just update the actual .js file?

@mathiasrw mathiasrw merged commit 35aa279 into AlaSQL:develop Mar 18, 2024
10 checks passed
@mathiasrw
Copy link
Member

Fix released as part of v4.3.1

@vishal6557
Copy link
Contributor Author

vishal6557 commented Mar 18, 2024

@mathiasrw No, I don't have a problem generating files from the jison

I think yarn jison command is broken, I manually install jison globally and using command
jison ./src/alasqlparser.jison -o ./src/alasqlparser.js

Can you try this command if it works, I'll create a pull request and update the package.json

@mathiasrw
Copy link
Member

mathiasrw commented Mar 21, 2024

Neat! Ill look into this!

@mathiasrw
Copy link
Member

It works. Neat!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid query throws n.Term is not a constructor
2 participants