Improve error message on invalid query to fix #1871 (#1903)

Co-authored-by: vishal diyora <vishaldiyora@vishals-MacBook-Pro-2.local>
AlaSQL · Mar 18, 2024 · 35aa279 · 35aa279
1 parent ce63775
commit 35aa279
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 8 deletions.
diff --git a/src/alasqlparser.jison b/src/alasqlparser.jison
@@ -2960,12 +2960,11 @@ TermsList
 	;
 
 Term
-	: Literal
-		{ $$ = new yy.Term({termid:$1}); }
-	| Literal LPAR TermsList RPAR
-		{ $$ = new yy.Term({termid:$1,args:$3}); }
-	;
-
+    : Literal
+        { $$ = {termid: $1}; }
+    | Literal LPAR TermsList RPAR
+        { $$ = {termid:$1, args:$3}; }
+    ;
 Query
 	: QUESTIONDASH FuncValue
 	;

diff --git a/src/alasqlparser.js b/src/alasqlparser.js
diff --git a/test/test1871.js b/test/test1871.js
@@ -0,0 +1,15 @@
+if (typeof exports === 'object') {
+	var assert = require('assert');
+	var alasql = require('..');
+}
+
+describe('Test 1871 - n.Term is not a constructor', function () {
+	it('Sending xxx random data should give valid error', function () {
+		assert.throws(
+			() => alasql('xxx'),
+			{
+				message: "Parse error on line 1:\nxxx\n---^\nExpecting 'COLONDASH', got 'EOF'",
+			}
+		);
+	});
+});