Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Python 2 #1622

Conversation

JeanChristopheMorinPerso
Copy link
Member

@JeanChristopheMorinPerso JeanChristopheMorinPerso commented Jan 28, 2024

Fixes #1551

This PR drops support for Python 2 entirely from the code base.

Things to do in follow-up PRs (should be done after 3.0 is released):

  • Remove rez.backports.importlib, rez.backports.ordereddict and rez.backports.zipfile.
  • See if we could unvendor rez.backports.lru_cache. It seems like we slightly modified it?
  • Remove rez.utils.py23. I did most of the work but we still need to remove get_function_arg_names and load_module_from_file.
  • See if we can replace rez.utils.data_utils.cached_property with functools.cached_property.
  • Remove/replace all deprecated (python 2) magic methods (__<method>__).
  • Remove from __future__ import print_function from the code base.
  • Look at PRs/commits that added support for Python 3 and see if we missed anything.
  • Potentially run https://github.com/asottile/pyupgrade.

@JeanChristopheMorinPerso JeanChristopheMorinPerso modified the milestone: 3.0.0 Feb 4, 2024
@JeanChristopheMorinPerso JeanChristopheMorinPerso marked this pull request as ready for review February 5, 2024 02:19
@JeanChristopheMorinPerso JeanChristopheMorinPerso requested a review from a team as a code owner February 5, 2024 02:19
Signed-off-by: Jean-Christophe Morin <jean_christophe_morin@hotmail.com>
@JeanChristopheMorinPerso JeanChristopheMorinPerso merged commit 2a9a99c into AcademySoftwareFoundation:main Feb 8, 2024
52 checks passed
@JeanChristopheMorinPerso JeanChristopheMorinPerso deleted the drop_python_2 branch February 8, 2024 00:24
Pixel-Minions pushed a commit to Pixel-Minions/rez that referenced this pull request Feb 14, 2024
Signed-off-by: Jean-Christophe Morin <jean_christophe_morin@hotmail.com>
Signed-off-by: Jose Enriquez <jose.enriquez@barnstormvfx.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop support for Python 2 entirely
1 participant