Wrong namespaces used in DWA Compressor. #131
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On a 32-bit architecture, these literals are too big for just a long, they need to be long long, otherwise I get an error in GCC.
As discusses in pull request AcademySoftwareFoundation#126
…teral Use LL for 64-bit literals
|
Actually, I'd strongly recommend merging it to v2.2.whatever. |
|
My fix is not complete: there are a bunch of other places in the code where Imf, Iex and Imath are used directly instead of OENEXR_IMG_NAMESPACE, IEX_NAMESPACE & co. across many files. I'd recommend that you start testing with non-default namespace names. |
|
Agreed. That's in progress. The testing, that is. |
|
I have some more of the missing namespace fixes in my fork https://github.com/KevinJW/openexr/tree/namespace_fixes specifically 04b1c7e at least allows me to build everything I normally do. Kevin |
|
manually merged after conflict and pushed. Also see #310 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
9d8289a