Use LL for 64-bit literals #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On a 32-bit architecture, these literals are too big for just a long, they need to be long long, otherwise I get an error in GCC.
|
Shouldn't these actually be 0x...ULL since Int64 is unsigned? |
|
Ah, good point. I think the way it'll underflow, you'll get to the same place, but may as well do it right. I can update the pull request if you like. |
|
Please do. |
As discusses in pull request AcademySoftwareFoundation#126
|
Done. |
ehanway-ilm
added a commit
that referenced
this pull request
Aug 15, 2014
Use LL for 64-bit literals
|
Please pull this to the develop branch as well. BTW, which policy for the branches to you have? It's a bit strange to see a commit pulled into master, but not into dev. |
|
The merge into master was an error. It should have gone into develop first. |
edgarv
pushed a commit
to edgarv/openexr
that referenced
this pull request
Jul 20, 2015
…re/LL_literal Use LL for 64-bit literals
KevinJW
pushed a commit
to KevinJW/openexr
that referenced
this pull request
Oct 29, 2015
As discusses in pull request AcademySoftwareFoundation#126
dracwyrm
pushed a commit
to dracwyrm/openexr
that referenced
this pull request
Jan 22, 2018
As discusses in pull request AcademySoftwareFoundation#126
barracuda156
added a commit
to barracuda156/powerpc-ports
that referenced
this pull request
Feb 6, 2024
pmetzger
pushed a commit
to macports/macports-ports
that referenced
this pull request
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On a 32-bit architecture, these literals are too big for just a long,
they need to be long long, otherwise I get an error in GCC.