Port from master to RB-2.1 - Fix add_test calls and change temporary file creation. (#1522) #1534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* * Fix add_test in cmake files. This notation allows it to understand that the command portion is a target and to translate it to the proper executable. * Remove starting backslash if present from temporary filename. A starting backslash mean that it is safe to create it in the current working directory. * Implement a public TempFile class. * Change relevant tests to use TempFile class. Signed-off-by: Patrick Northon <northon_patrick3@yahoo.ca> * * Revert back changes for TempFile class. * Add comment on temporary file functions fix. Signed-off-by: Patrick Northon <northon_patrick3@yahoo.ca> * Add FIXME comments. Signed-off-by: Patrick Northon <northon_patrick3@yahoo.ca> * Add -C flag to ctest commands. Signed-off-by: Patrick Northon <northon_patrick3@yahoo.ca> * Add `-C Release` to ctest commands in `analysis_workflow.yml`. Signed-off-by: Patrick Northon <northon_patrick3@yahoo.ca> Co-authored-by: Patrick Hodoul <patrick.hodoul@autodesk.com> Co-authored-by: Rémi Achard <remiachard@gmail.com> Signed-off-by: Patrick Hodoul <Patrick.Hodoul@autodesk.com>
hodoulp
force-pushed
the
adsk_contrib/integration_21_11
branch
from
6105269
to
2c39db0
Compare
remia
approved these changes
Nov 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Patrick Northon northon_patrick3@yahoo.ca
Signed-off-by: Patrick Northon northon_patrick3@yahoo.ca
Signed-off-by: Patrick Northon northon_patrick3@yahoo.ca
Signed-off-by: Patrick Northon northon_patrick3@yahoo.ca
-C Releaseto ctest commands inanalysis_workflow.yml.Signed-off-by: Patrick Northon northon_patrick3@yahoo.ca
Co-authored-by: Patrick Hodoul patrick.hodoul@autodesk.com
Co-authored-by: Rémi Achard remiachard@gmail.com