Fix add_test calls and change temporary file creation.

[patlefort]

Followup from my previous PR (#1487)

• Fix add_test in cmake files. This notation allows it to understand that the command portion is a target and to translate it to the proper executable.
• Remove starting backslash if present from temporary filename. A starting backslash mean that it is safe to create it in the current working directory.
• Implement a public TempFile class.
• Change relevant tests to use TempFile class.

I've implemented a public TempFile class. I've put it in the OCIO namespace, is it fine? Should I put it in the Platform namespace? Also, GPUHelpers.h/cpp are left empty, should they be removed?

Signed-off-by: Patrick Northon northon_patrick3@yahoo.ca

[remia]

Thanks for the follow-up work @patlefort.

[patlefort]

test 1
    Start 1: test_utils_exec
Test not available without configuration.  (Missing "-C <config>"?)

I think the workflow running the tests is missing an option: tests running with ctest should have the option -C <config> so tests on multi-configuration generators can run properly. Or maybe run cmake --build . --target test --config <config>.

[patlefort]

Using ctest -V -C ${{ matrix.build-type }} work fine: https://github.com/patlefort/OpenColorIO/actions/runs/1393147487

[remia]

For some reasons it looks like it was working correctly before the update to the add_test commands. I think you can go ahead and add the -C flag to the ctest calls like you propose.

[remia]

@patlefort Could you also add the ctest -C flag to the analysis_workflow.yml file (hard-coded to Release) so that this doesn't break? I believe it is then ready for merge.