Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#426 Fix addPipelineNotificationFailure() not being called. #437

Conversation

yruslan
Copy link
Collaborator

@yruslan yruslan commented Jul 15, 2024

This resulted in pipeline custom notification failures were not part of notification emails.

Closes #426

This resulted in pipeline custom notification failures were not part of notification emails.
Copy link

Unit Test Coverage

File Coverage [100%] 🍏
PipelineNotificationDirector.scala 100% 🍏
Total Project Coverage 82.17% 🍏

@yruslan yruslan requested a review from VladimirRybalko July 15, 2024 13:09
@yruslan yruslan merged commit 8fb1aef into main Jul 15, 2024
8 checks passed
@yruslan yruslan deleted the feature/426-add-pipeline-notification0failures-to-email-notifications branch July 15, 2024 14:15
@yruslan yruslan mentioned this pull request Jul 19, 2024
yruslan added a commit that referenced this pull request Aug 2, 2024
yruslan added a commit that referenced this pull request Aug 2, 2024
yruslan added a commit that referenced this pull request Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

addPipelineNotificationFailure() seems to be not used
2 participants