#426 Fix addPipelineNotificationFailure() not being called.

This resulted in pipeline custom notification failures were not part of notification emails.
AbsaOSS · Jul 15, 2024 · 8fb1aef · 8fb1aef
1 parent 867a714
commit 8fb1aef
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/.../src/main/scala/za/co/absa/pramen/core/notify/pipeline/PipelineNotificationDirector.scala b/.../src/main/scala/za/co/absa/pramen/core/notify/pipeline/PipelineNotificationDirector.scala
@@ -49,6 +49,10 @@ object PipelineNotificationDirector {
       .tasksCompleted
       .foreach(notificationBuilder.addCompletedTask)
 
+    notification.pipelineNotificationFailures.foreach(pipelineNotificationFailure =>
+      notificationBuilder.addPipelineNotificationFailure(pipelineNotificationFailure)
+    )
+
     notificationBuilder.addCustomEntries(notification.customEntries)
     notificationBuilder.addSignature(notification.customSignature: _*)
 

diff --git a/...cala/za/co/absa/pramen/core/tests/notify/pipeline/PipelineNotificationDirectorSuite.scala b/...cala/za/co/absa/pramen/core/tests/notify/pipeline/PipelineNotificationDirectorSuite.scala
@@ -19,7 +19,7 @@ package za.co.absa.pramen.core.tests.notify.pipeline
 import com.typesafe.config.{Config, ConfigFactory}
 import org.scalatest.wordspec.AnyWordSpec
 import za.co.absa.pramen.api.notification.{NotificationEntry, TextElement}
-import za.co.absa.pramen.api.status.RunStatus
+import za.co.absa.pramen.api.status.{PipelineNotificationFailure, RunStatus}
 import za.co.absa.pramen.core.mocks.notify.PipelineNotificationBuilderSpy
 import za.co.absa.pramen.core.mocks.{PipelineNotificationFactory, SchemaDifferenceFactory, TaskResultFactory}
 import za.co.absa.pramen.core.notify.pipeline.PipelineNotificationDirector
@@ -49,9 +49,10 @@ class PipelineNotificationDirectorSuite extends AnyWordSpec {
       val taskCompleted3 = TaskResultFactory.getDummyTaskResult(schemaDifferences = schemaDifferences)
 
       val customEntries = List(NotificationEntry.Paragraph(TextElement("1") :: Nil), NotificationEntry.Paragraph(TextElement("1") :: Nil))
+      val pipelineNotificationFailures = List(PipelineNotificationFailure("Dummy Reason", new IllegalStateException("Dummy")))
 
       val notification = PipelineNotificationFactory.getDummyNotification(exception = Some(ex2), tasksCompleted =
-        List(taskCompleted1, taskCompleted2, taskCompleted3), customEntries = customEntries)
+        List(taskCompleted1, taskCompleted2, taskCompleted3), customEntries = customEntries, pipelineNotificationFailures = pipelineNotificationFailures)
 
       val builderSpy = new PipelineNotificationBuilderSpy
 
@@ -68,6 +69,7 @@ class PipelineNotificationDirectorSuite extends AnyWordSpec {
       assert(builderSpy.goodRps == 2000)
       assert(builderSpy.addCompletedTaskCalled == 3)
       assert(builderSpy.addCustomEntriesCalled == 1)
+      assert(builderSpy.addPipelineNotificationFailure == 1)
     }
   }