Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#192 Add ability for a data source to be validated and return validation errors and warnings #193

Merged
merged 4 commits into from
May 23, 2023

Conversation

yruslan
Copy link
Collaborator

@yruslan yruslan commented May 19, 2023

  • validate() added to the Source interface so that custom sources can validate themselves
  • Validations can return warnings which will end up in notifications, but won't fail a job

yruslan added 3 commits May 17, 2023 10:06

Verified

This commit was signed with the committer’s verified signature.
yruslan Ruslan Yushchenko
…warnings are the result of such validations.

Verified

This commit was signed with the committer’s verified signature.
yruslan Ruslan Yushchenko

Verified

This commit was signed with the committer’s verified signature.
yruslan Ruslan Yushchenko
@yruslan yruslan marked this pull request as ready for review May 22, 2023 07:12
@yruslan yruslan requested a review from jirifilip as a code owner May 22, 2023 07:12

Verified

This commit was signed with the committer’s verified signature.
yruslan Ruslan Yushchenko
Copy link
Collaborator

@jirifilip jirifilip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I like the idea of the SourceMock. It could be even used for teaching users to use Pramen and build pipelines (so that they don't have to worry about setting up JDBC or CSV source)

@yruslan yruslan merged commit 6441b7a into main May 23, 2023
@yruslan yruslan deleted the feature/192-add-source-validation branch May 23, 2023 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants