Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to validate a source #192

Closed
yruslan opened this issue May 5, 2023 · 0 comments
Closed

Add the ability to validate a source #192

yruslan opened this issue May 5, 2023 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@yruslan
Copy link
Collaborator

yruslan commented May 5, 2023

Background

Currently exceptions thrown at sources's getRecordCount() is considered a validation error.
This is confusing and combines 2 concerns in one method.

Feature

Add validate() method to the Source interface

The validate method should allow returning errors as well as just warnings depending on the source configuration.

Proposed Solution

validate() method of the Source interface should have default implementation to return Ready. This will keep the interface backwards compatible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant