-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the ability to validate a source #192
Labels
enhancement
New feature or request
Comments
yruslan
added a commit
that referenced
this issue
May 17, 2023
…warnings are the result of such validations.
yruslan
added a commit
that referenced
this issue
May 19, 2023
yruslan
added a commit
that referenced
this issue
May 19, 2023
yruslan
added a commit
that referenced
this issue
May 22, 2023
yruslan
added a commit
that referenced
this issue
May 23, 2023
…warnings are the result of such validations.
yruslan
added a commit
that referenced
this issue
May 23, 2023
yruslan
added a commit
that referenced
this issue
May 23, 2023
yruslan
added a commit
that referenced
this issue
May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Background
Currently exceptions thrown at sources's
getRecordCount()
is considered a validation error.This is confusing and combines 2 concerns in one method.
Feature
Add
validate()
method to theSource
interfaceThe validate method should allow returning errors as well as just warnings depending on the source configuration.
Proposed Solution
validate()
method of theSource
interface should have default implementation to returnReady
. This will keep the interface backwards compatible.The text was updated successfully, but these errors were encountered: