Skip to content

Commit

Permalink
Switch to log-acqfs (emdgroup#326)
Browse files Browse the repository at this point in the history
This PR changes the default acquisition function from `qEI` to
`qLogEI`, which improves numerical stability and also avoids the warning
thrown in `botorch>=0.11.3`.
  • Loading branch information
AdrianSosic authored Jul 31, 2024
2 parents fc7d362 + 7e7fd26 commit ebb17d9
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
two fixed low and high dimensional prior regimes
- The previous default kernel factory has been renamed to `EDBOKernelFactory` and now
fully reflects the original logic
- The default acquisition function has been changed from "qEI" to "qLogEI" for improved
numerical stability

### Removed
- Support for Python 3.9 removed due to new [BoTorch requirements](https://github.com/pytorch/botorch/pull/2293)
Expand Down
4 changes: 2 additions & 2 deletions baybe/recommenders/pure/bayesian/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
import pandas as pd
from attrs import define, field

from baybe.acquisition.acqfs import qExpectedImprovement
from baybe.acquisition.acqfs import qLogExpectedImprovement
from baybe.acquisition.base import AcquisitionFunction
from baybe.acquisition.utils import convert_acqf
from baybe.exceptions import DeprecationError
Expand All @@ -25,7 +25,7 @@ class BayesianRecommender(PureRecommender, ABC):
"""The used surrogate model."""

acquisition_function: AcquisitionFunction = field(
converter=convert_acqf, factory=qExpectedImprovement
converter=convert_acqf, factory=qLogExpectedImprovement
)
"""The used acquisition function class."""

Expand Down

0 comments on commit ebb17d9

Please sign in to comment.