Switch to log-acqfs #326
Merged
Switch to log-acqfs #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This improves numerical stability and also avoids the warning thrown in botorch>=0.11.3
AdrianSosic
commented
Jul 26, 2024
Scienfitz
reviewed
Jul 26, 2024
AVHopp
requested changes
Jul 28, 2024
Instead of remapping, we only adjust the defaults
Scienfitz
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
maps the regular "EI" acquisition functions to their "log" versionschanges the default acquisition function fromqEItoqLogEI, which improves numerical stability and also avoids the warning thrown inbotorch>=0.11.3.