Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up KtLint #71

Merged
merged 7 commits into from
Nov 5, 2024
Merged

Set up KtLint #71

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
5fc5eb6
Add ktlint
shubertm Aug 8, 2024
2662cc2
Add lint check to CI
shubertm Aug 8, 2024
801e7a3
Use plugin for ktlint
shubertm Sep 1, 2024
00c875d
Merge remote-tracking branch 'origin/main' into enhance/ktlint
shubertm Nov 4, 2024
88070d8
Fix KtLint issues
shubertm Nov 4, 2024
1e2b6c6
Add post notification permission
shubertm Nov 5, 2024
2cfdab9
Fix Unsafe call to observe with Fragment instance as LifecycleOwner
shubertm Nov 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions app/src/main/AndroidManifest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
<uses-permission android:name="android.permission.READ_EXTERNAL_STORAGE"/>
<uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE"/>
<uses-permission android:name="android.permission.RECORD_AUDIO"/>
<uses-permission android:name="android.permission.POST_NOTIFICATIONS"/>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shubertm For which reason do we need this permission?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can check the lint error here https://github.com/ARK-Builders/ARK-Memo/actions/runs/11668539341/job/32488691548. Seems glide posts some notifications. Yet am not really sure


<application
android:name=".App"
Expand Down
Loading