Set up KtLint #71
Merged
Set up KtLint #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shubertm
had a problem deploying
to
Development
GitHub Actions
Failure
|
@shubertm Could you describe the changes in this PR please? |
# Conflicts: # app/build.gradle # app/src/main/java/dev/arkbuilders/arkmemo/App.kt # app/src/main/java/dev/arkbuilders/arkmemo/graphics/SVG.kt # app/src/main/java/dev/arkbuilders/arkmemo/media/ArkAudioRecorderImpl.kt # app/src/main/java/dev/arkbuilders/arkmemo/media/ArkMediaPlayer.kt # app/src/main/java/dev/arkbuilders/arkmemo/media/ArkMediaPlayerImpl.kt # app/src/main/java/dev/arkbuilders/arkmemo/models/GraphicNote.kt # app/src/main/java/dev/arkbuilders/arkmemo/models/SaveNoteResult.kt # app/src/main/java/dev/arkbuilders/arkmemo/models/TextNote.kt # app/src/main/java/dev/arkbuilders/arkmemo/models/VoiceNote.kt # app/src/main/java/dev/arkbuilders/arkmemo/preferences/MemoPreferences.kt # app/src/main/java/dev/arkbuilders/arkmemo/preferences/MemoPreferencesImpl.kt # app/src/main/java/dev/arkbuilders/arkmemo/repo/NotesRepoHelper.kt # app/src/main/java/dev/arkbuilders/arkmemo/repo/graphics/GraphicNotesRepo.kt # app/src/main/java/dev/arkbuilders/arkmemo/repo/text/TextNotesRepo.kt # app/src/main/java/dev/arkbuilders/arkmemo/repo/voices/VoiceNotesRepo.kt # app/src/main/java/dev/arkbuilders/arkmemo/ui/activities/MainActivity.kt # app/src/main/java/dev/arkbuilders/arkmemo/ui/adapters/NotesListAdapter.kt # app/src/main/java/dev/arkbuilders/arkmemo/ui/dialogs/NoteDeleteDialog.kt # app/src/main/java/dev/arkbuilders/arkmemo/ui/fragments/ArkMediaPlayerFragment.kt # app/src/main/java/dev/arkbuilders/arkmemo/ui/fragments/ArkRecorderFragment.kt # app/src/main/java/dev/arkbuilders/arkmemo/ui/fragments/BaseEditNoteFragment.kt # app/src/main/java/dev/arkbuilders/arkmemo/ui/fragments/EditGraphicNotesFragment.kt # app/src/main/java/dev/arkbuilders/arkmemo/ui/fragments/EditTextNotesFragment.kt # app/src/main/java/dev/arkbuilders/arkmemo/ui/fragments/NotesFragment.kt # app/src/main/java/dev/arkbuilders/arkmemo/ui/fragments/SettingsFragment.kt # app/src/main/java/dev/arkbuilders/arkmemo/ui/viewmodels/ArkMediaPlayerViewModel.kt # app/src/main/java/dev/arkbuilders/arkmemo/ui/viewmodels/ArkRecorderViewModel.kt # app/src/main/java/dev/arkbuilders/arkmemo/ui/viewmodels/GraphicNotesViewModel.kt # app/src/main/java/dev/arkbuilders/arkmemo/ui/viewmodels/NotesViewModel.kt # app/src/main/java/dev/arkbuilders/arkmemo/ui/views/NotesCanvas.kt # app/src/main/java/dev/arkbuilders/arkmemo/ui/views/WaveView.kt # app/src/main/java/dev/arkbuilders/arkmemo/utils/Config.kt # app/src/main/java/dev/arkbuilders/arkmemo/utils/NoteExt.kt # app/src/main/java/dev/arkbuilders/arkmemo/utils/Utils.kt # build.gradle
shubertm
had a problem deploying
to
Development
GitHub Actions
Failure
hieuwu
approved these changes
Nov 4, 2024
shubertm
had a problem deploying
to
Development
GitHub Actions
Failure
tuancoltech
reviewed
Nov 7, 2024
| @@ -10,6 +10,7 @@ | |||
| <uses-permission android:name="android.permission.READ_EXTERNAL_STORAGE"/> | |||
| <uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE"/> | |||
| <uses-permission android:name="android.permission.RECORD_AUDIO"/> | |||
| <uses-permission android:name="android.permission.POST_NOTIFICATIONS"/> | |||
There was a problem hiding this comment.
@shubertm For which reason do we need this permission?
There was a problem hiding this comment.
You can check the lint error here https://github.com/ARK-Builders/ARK-Memo/actions/runs/11668539341/job/32488691548. Seems glide posts some notifications. Yet am not really sure
tuancoltech
reviewed
Nov 7, 2024
Comment on lines
-13
to
+14
| Intent(Intent.ACTION_VIEW).setData(Uri.parse(url))) | ||
| Intent(Intent.ACTION_VIEW).setData(Uri.parse(url)), | ||
| ) |
There was a problem hiding this comment.
@shubertm I don't see the point of adding an extra comma to the end of this line, or in any other parameterized blocks.
Could you elaborate?
There was a problem hiding this comment.
I think we need to change the ktlint rules for trailing commas. Disallow them
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The aim of this PR is to enforce Kotlin code style across Memo developers using KtLint plugin.And this makes it easier for new developers too, they can concentrate on solving the actual problem instead of spending much time on formatting code. In most ARK Kotlin repos we are using https://github.com/JLLeitschuh/ktlint-gradle, here as well