Newlines in custom data are shown as \n in emails

[scompt]

Newlines are escaped in CustomDataCollector, presumably for a good reason somewhere else in the code. However, when I send a report via email, the custom data contains the escaped newlines (\n) in the custom data instead of real newlines. Is there just a step missing in EmailIntentSender?

This is the code I'm using to update the custom data. I'm keeping a log by appending messages to a single custom data key.

            String log = errorReporter.getCustomData(LOG_KEY);
            if (log == null) {
                log = fullMessage;
            } else {
                log = String.format("%s%n%s", log, fullMessage);
            }

            errorReporter.putCustomData(LOG_KEY, log);

I'm using version 4.9.1, but have also tested with the development version and the problem still exists.

[william-ferguson-au]

What version of ACRA?

[scompt]

4.9.1

I haven't tested yet with the current state of the repository. I'll do that now.

[scompt]

@william-ferguson-au The probably also exists in the current code. I've updated the issue with some code.

[william-ferguson-au]

Yeah, looks like you need to transform the customData from \\n back to \n

[scompt]

@william-ferguson-au I think I've fixed it with this pull request. Can you take a look?

[william-ferguson-au]

I don't believe value can ever be null. If it is listed as a field then it should always have a value. And the previous code would have broken on line 74 with an NullPointerException.

[william-ferguson-au]

I don't believe value can ever be null. If it is listed as a field then it should always have a value. And the previous code would have broken on line 74 with an NullPointerException.

[F43nd1r]

Correct. There is a de-facto null-value, which is AcraConstants.NOT_AVAILABLE, but a collector returning null would be a bug.

[william-ferguson-au]

I don't believe value can ever be null. If it is listed as a field then it should always have a value. And the previous code would have broken on line 74 with an NullPointerException.

[scompt]

My first implementation didn't have the null check, but I got a NullPointerException. I didn't look into it any further, but I think it might be because the "user comment" was null. I've seen that in the email that gets sent. StringBuilder.append inserts "null" into the string if the argument is null, so I don't think anything will crash if a null is around.

[F43nd1r]

Does this problem exist with the json implementation? See #523

If not, this would be another reason to adopt that structure.

[william-ferguson-au]

@F43nd1r Kevin has added you as team member, so you can merge in these and other changes.
Thanks for your help.

[F43nd1r]

@william-ferguson-au thanks for that. But I think it won't change much on my workflow, as I won't be merging anything without talking about it with you and/or Kevin.

While I would like to merge the json PR, I'll have to test it some more, as I noticed that the EmailSender will output some json, which should not be the case.

[F43nd1r]

Closing because the problem was solved with #523