Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to json #523

Merged
merged 10 commits into from
Dec 21, 2016
Merged

Switch to json #523

merged 10 commits into from
Dec 21, 2016

Conversation

F43nd1r
Copy link
Member

@F43nd1r F43nd1r commented Oct 13, 2016

It's hard to say that something this big is complete, but I can say that it is working. I compared the output of 4.9.1 and this. Results were similar with a few differences:

  • Some Numbers are now Strings (and the other way around) because that is the type of the field they come from (types are no longer guessed but carried over from the source)
  • Shared preferences keys are no longer split at dots (this is a wanted change)
  • Some String arrays are now actually arrays ( "[x86, x86_64]" is now ["x86", "x86_64"])
  • Due to the json limitation that a key is only saved with a value, device features are now assigned to true even in form mode (previously this was only the case in json mode)
  • All not available fields now contain the standardized string "N/A", instead of just some of them.

Resolves #517.

Reports are saved as json (utf-8 encoded) instead of the custom format. I chose utf-8 because it is the java internal encoding and thus guarantees no problems with custom data and other user supplied strings.
Old reports will be converted by ReportConverter.
Legacy migration and conversion has been grouped in LegacyFileHandler.
JsonReportBuilder has been replaced with JsonUtils.

@F43nd1r
Copy link
Member Author

F43nd1r commented Dec 21, 2016

@william-ferguson-au According to what I have tested, this is working now. However I do not want to merge this amount of change without confirmation. Is there something I should think of/check before merging this?

@william-ferguson-au
Copy link
Member

I can't think of anything.
Merge it and we'll deal with the fallout (if there is any).

@F43nd1r F43nd1r merged commit 48cdba1 into ACRA:master Dec 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants