Call finish on UI thread #465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The problem is not calling |
|
OK, I added a commit that should let the activity complete its lifecycle before the process is killed. |
|
It looks like android is reusing the main process for the dialog. I think it is good to run the dialog on the :acra process anyway, becasue it prevents infinite loops in case of a crashing dialog. (this couldn't happen before, because we killed the process before the dialog had a chance to take it over.) I also noticed that if the activity crashed on its main thread, it won't call onStop anymore, so it is useless to wait for that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #464