ACRA may fail if last Activity touches views on Activity#finish()

[william-ferguson-au]

ReportExecutor#endApplication#290 in 4.8.5 maps to line#265 in master.

May need to call lastActivity from handler thread. Which has issues wrt killing off the application.

NB this was with ACRA-4.8.5

android.view.ViewRootImpl$CalledFromWrongThreadException: Only the original thread that created a view hierarchy can touch its views.
at android.view.ViewRootImpl.checkThread(ViewRootImpl.java:7099)
at android.view.ViewRootImpl.clearChildFocus(ViewRootImpl.java:3316)
at android.view.ViewGroup.clearChildFocus(ViewGroup.java:800)
at android.view.ViewGroup.clearChildFocus(ViewGroup.java:800)
at android.view.ViewGroup.clearChildFocus(ViewGroup.java:800)
at android.view.ViewGroup.clearChildFocus(ViewGroup.java:800)
at android.view.ViewGroup.clearChildFocus(ViewGroup.java:800)
at android.view.View.clearFocusInternal(View.java:4955)
at android.view.View.clearFocus(View.java:4938)
at android.view.ViewGroup.clearFocus(ViewGroup.java:813)
at com.millennialmedia.android.AdViewOverlayView.h(SourceFile:710)
at com.millennialmedia.android.AdViewOverlayActivity.finish(SourceFile:174)
at com.millennialmedia.android.MMActivity.finish(SourceFile:272)
at org.acra.builder.ReportExecutor.endApplication(SourceFile:290)
at org.acra.builder.ReportExecutor.access$600(SourceFile:40)
at org.acra.builder.ReportExecutor$3.run(SourceFile:257)

[F43nd1r]

An activity should not do any work in finish. This should instead be done in onPause, onStop or onDestroy, depending on the usecase.

However, it should be no problem to call finish on the UI thread.

[william-ferguson-au]

Agree 100% that an Activity should not be touching its UI in #finish(). However we don't always write/control all the Activities in our apps.