Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Configs CI Infrastructure #18

Merged
merged 9 commits into from
Aug 7, 2024
Merged

Add Configs CI Infrastructure #18

merged 9 commits into from
Aug 7, 2024

Conversation

CodeGat
Copy link
Collaborator

@CodeGat CodeGat commented Jun 19, 2024

Used template Configs CI Infrastructure from ACCESS-NRI/model-configs-template@20a7c6d as this repository existed before the template!

In this PR:

  • Added .github/workflows
  • Added basic configs/ci.yml
  • Added README-DEV.md, CONTRIBUTING.md, .gitignore
  • Updated README.md

Closes #15

@CodeGat
Copy link
Collaborator Author

CodeGat commented Jun 19, 2024

@aidanheerdegen I might need a hand on the bits in the README.md that say <<<FIXME: something>>> :D

aidanheerdegen
aidanheerdegen previously approved these changes Aug 5, 2024
Copy link
Member

@aidanheerdegen aidanheerdegen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/config.yml Outdated Show resolved Hide resolved
.github/workflows/generate-initial-checksums.yml Outdated Show resolved Hide resolved
.github/workflows/schedule.yml Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Member

@aidanheerdegen aidanheerdegen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More changes/comments.

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
CodeGat and others added 3 commits August 6, 2024 09:22
Co-authored-by: Aidan Heerdegen <aidan.heerdegen@anu.edu.au>
Co-authored-by: Aidan Heerdegen <aidan.heerdegen@anu.edu.au>
@aidanheerdegen
Copy link
Member

I have created a sympathetic/related PR to add a CITATION.cff file

#41

Copy link
Member

@aidanheerdegen aidanheerdegen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More suggestions. I'm full of them.

README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Member

@aidanheerdegen aidanheerdegen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's get this puppy merged.

@CodeGat CodeGat merged commit 45e2f43 into main Aug 7, 2024
1 check passed
@CodeGat CodeGat deleted the 15-add-ci branch August 12, 2024 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Configs CI
2 participants