Mkmf escape fix #11
Merged
Mkmf escape fix #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodeGat
force-pushed
the
mkmf-escape-fix
branch
2 times, most recently
from
17077fe
to
a22def9
Compare
…for non-assignment operations
CodeGat
force-pushed
the
mkmf-escape-fix
branch
from
66bbc2f
to
5f70241
Compare
|
Don't worry about the failing final check...that is a CI issue that I shall fix... |
aidanheerdegen
approved these changes
Nov 8, 2023
|
I looked into @harshula s links in the megathread and the answers were all substituting rather than escaping, so I went with that. |
|
Notes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mkmffails to generate a valid Makefile when directories have=in them because it is a reserved word.This PR reads in the created Makefile and substitues all non-assignment
=with$(EQUALS)(whereEQUALS = =).Closes #9 !