Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spack build fails when using mom5@git.tag in spec #9

Closed
CodeGat opened this issue Nov 5, 2023 · 0 comments · Fixed by #11
Closed

Spack build fails when using mom5@git.tag in spec #9

CodeGat opened this issue Nov 5, 2023 · 0 comments · Fixed by #11
Assignees
@CodeGat

Comments

@CodeGat
Copy link

CodeGat commented Nov 5, 2023

Background
After a bit of falling down the rabbit hole with @aidanheerdegen and @harshula, we discovered that:

  • Spack adds a bit of extra metadata to the @git.tag versioning system, in which '=' is the delimiter.
  • This interferes with the makefile, as '=' is reserved, and the build fails.

Solution

  • Escape the '=' by setting an alias(?) in the makefile templating program mom5/bin/mkmf like so: EQUALS = =. Maybe make this a subroutine.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CodeGat CodeGat

Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@CodeGat