Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR now notifies you of spack-{packages,config} version about to be deployed #36

Merged
merged 3 commits into from
Feb 5, 2024
Merged

PR now notifies you of spack-{packages,config} version about to be deployed #36

merged 3 commits into from
Feb 5, 2024

Conversation

CodeGat
Copy link
Member

@CodeGat CodeGat commented Feb 5, 2024

Closes #32

@CodeGat CodeGat self-assigned this Feb 5, 2024
aidanheerdegen
aidanheerdegen previously approved these changes Feb 5, 2024
View reviewed changes
Copy link
Member

@aidanheerdegen aidanheerdegen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine, just had a question.

.github/workflows/ci.yml Outdated Show resolved Hide resolved
aidanheerdegen
aidanheerdegen approved these changes Feb 5, 2024
View reviewed changes
Copy link
Member

@aidanheerdegen aidanheerdegen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM^2

@CodeGat CodeGat merged commit 2696fcb into main Feb 5, 2024
@CodeGat CodeGat deleted the 32-ci-versions-comment branch February 5, 2024 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aidanheerdegen aidanheerdegen aidanheerdegen approved these changes

Assignees

@CodeGat CodeGat

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI: Note in the PR the versions contained in config/versions.json
2 participants
@CodeGat @aidanheerdegen