Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Note in the PR the versions contained in config/versions.json #32

Closed
CodeGat opened this issue Jan 23, 2024 · 0 comments · Fixed by #36
Closed

CI: Note in the PR the versions contained in config/versions.json #32

CodeGat opened this issue Jan 23, 2024 · 0 comments · Fixed by #36

Comments

@CodeGat
Copy link
Member

CodeGat commented Jan 23, 2024

In #31 I had to note that config/versions.json may need to be modified because that is the file that sources the versions of spack-config and spack-packages that are used in the deployment.

This would be annoying to do for every PR and probably also speaks to a lack of documentation on my part.

Potential Solutions

  • Add a recreating comment on commit on a PR via CI noting the versions that will be used in the deployment. For example, "This spack.yaml will deploy access-om2 with spack-config 2024.01.01 and spack-packages 2024.01.01. If these are not the correct versions, modify config/versions.json"
  • Add this information to the README.md or a CONTRIBUTING file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant