-
Notifications
You must be signed in to change notification settings - Fork 363
[L2-UX] Indicate chain id in transaction popups #2721
[L2-UX] Indicate chain id in transaction popups #2721
Conversation
CLA Assistant Lite All Contributors have signed the CLA. |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
E2E Tests Failed Failed tests:
|
…d-in-transaction-popups
I can't connect to the application at all. I tried in Rinkeby and Polygon and is the same for both networks |
const classes = useStyles() | ||
const connectedNetwork = useSelector(networkSelector) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should actually be useSelector(currentChainId)
.
We should indicate the contract/chain the app is pointing to, not the wallet connection.
@francovenica this bug is on the l2-ux branch, I'll fix it. |
…9-chain-id-in-transaction-popups
I still cannot connect with any wallet. I'll check with @juampibermani |
@katspaugh @francovenica @juampibermani Bug with hardware wallets was on L2-UX branch. I was working on that while solving the multiple clicks issue. Now it should be solved |
E2E Tests Failed Failed tests:
|
Ok, I can connect the wallet now and work on the ticket. Thanks @dasanra |
E2E Tests Failed Failed tests:
|
E2E Tests Failed Failed tests:
|
E2E Tests Failed Failed tests:
|
Looks good now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something is wrong with this branch. I see changes that aren't related to this PR.
@katspaugh there is a direct merge from |
src/routes/safe/components/Apps/components/ConfirmTxModal/ReviewConfirm.tsx
Outdated
Show resolved
Hide resolved
src/routes/safe/components/Apps/components/SignMessageModal/ReviewMessage.tsx
Outdated
Show resolved
Hide resolved
src/routes/safe/components/Balances/SendModal/screens/ContractInteraction/Review/index.tsx
Outdated
Show resolved
Hide resolved
...utes/safe/components/Balances/SendModal/screens/ContractInteraction/ReviewCustomTx/index.tsx
Outdated
Show resolved
Hide resolved
src/routes/safe/components/Settings/ManageOwners/EditOwnerModal/index.tsx
Outdated
Show resolved
Hide resolved
src/routes/safe/components/Settings/SpendingLimit/RemoveLimitModal.tsx
Outdated
Show resolved
Hide resolved
src/routes/safe/components/Settings/ThresholdSettings/ChangeThreshold/index.tsx
Outdated
Show resolved
Hide resolved
src/routes/safe/components/Transactions/TxList/modals/ApproveTxModal.tsx
Outdated
Show resolved
Hide resolved
src/routes/safe/components/Transactions/TxList/modals/RejectTxModal.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Dani!
What it solves
Resolves #2619
I also created a ModalHeader component so we don't repeat the same header and styles on each component