Skip to content
This repository has been archived by the owner on Nov 10, 2023. It is now read-only.

[L2-UX] Indicate chain id in transaction popups #2721

Merged
merged 12 commits into from
Sep 22, 2021

Conversation

juampibermani
Copy link
Contributor

What it solves

Resolves #2619

I also created a ModalHeader component so we don't repeat the same header and styles on each component

@juampibermani juampibermani requested review from mmv08, DaniSomoza, katspaugh and dasanra and removed request for mmv08 September 13, 2021 20:13
@github-actions
Copy link

CLA Assistant Lite All Contributors have signed the CLA.

@juampibermani juampibermani changed the base branch from dev to l2-ux September 13, 2021 20:13
@github-actions
Copy link

github-actions bot commented Sep 13, 2021

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@github-actions
Copy link

@github-actions
Copy link

@github-actions
Copy link

github-actions bot commented Sep 13, 2021

E2E Tests Failed
Check the results here: https://github.com/gnosis/safe-react-e2e-tests/actions/runs/1260884057

Failed tests:

  • ❌ Add an existing safe Add an existing safe

@github-actions
Copy link

@francovenica
Copy link
Contributor

I can't connect to the application at all. I tried in Rinkeby and Polygon and is the same for both networks
With MM it throws no error what so ever, but It just won't connect at all
I tried with the Trezor device, but it throws an error

Gif for the MM conection:
09-14-2021_x(2980)

Snapshot of the error I get with Trezor:
image

const classes = useStyles()
const connectedNetwork = useSelector(networkSelector)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should actually be useSelector(currentChainId).
We should indicate the contract/chain the app is pointing to, not the wallet connection.

@katspaugh
Copy link
Member

@francovenica this bug is on the l2-ux branch, I'll fix it.

@francovenica
Copy link
Contributor

I still cannot connect with any wallet. I'll check with @juampibermani

@dasanra
Copy link
Collaborator

dasanra commented Sep 16, 2021

@katspaugh @francovenica @juampibermani Bug with hardware wallets was on L2-UX branch. I was working on that while solving the multiple clicks issue. Now it should be solved

@github-actions
Copy link

E2E Tests Failed
Check the results here: https://github.com/gnosis/safe-react-e2e-tests/actions/runs/1242045107

Failed tests:

  • ❌ Add an existing safe Add an existing safe

@francovenica
Copy link
Contributor

francovenica commented Sep 16, 2021

Ok, I can connect the wallet now and work on the ticket. Thanks @dasanra

@francovenica
Copy link
Contributor

Send funds, send collectibles and contract interactions are fine.

Issue:
In the issue ticket it says "Affects: Send ERC20s, Send collectibles, contract interaction, Safe app tx flow"

The safe app tx workflow don't show the icon. Was that idea scrapped at some point?
image

@github-actions
Copy link

E2E Tests Failed
Check the results here: https://github.com/gnosis/safe-react-e2e-tests/actions/runs/1243078023

Failed tests:

  • ❌ Add an existing safe Add an existing safe

@katspaugh katspaugh changed the title Feature/2619 chain id in transaction popups [L2-UX] Indicate chain id in transaction popups Sep 17, 2021
@github-actions
Copy link

E2E Tests Failed
Check the results here: https://github.com/gnosis/safe-react-e2e-tests/actions/runs/1246287269

Failed tests:

  • ❌ Add an existing safe Add an existing safe

@francovenica
Copy link
Contributor

A few places where the indicator is missing:
Add owner, replace owner, delete owner. For all 3 forms, only the very last step shows the icon:

09-17-2021_x(2999)

@github-actions
Copy link

E2E Tests Failed
Check the results here: https://github.com/gnosis/safe-react-e2e-tests/actions/runs/1254565078

Failed tests:

  • ❌ Add an existing safe Add an existing safe

@francovenica
Copy link
Contributor

Looks good now.

Copy link
Member

@katspaugh katspaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something is wrong with this branch. I see changes that aren't related to this PR.

@dasanra
Copy link
Collaborator

dasanra commented Sep 21, 2021

@katspaugh there is a direct merge from dev when this branch should only bring changes from l2-ux to keep consistency. Will fix it

https://github.com/gnosis/safe-react/pull/2721/commits

@dasanra dasanra requested a review from katspaugh September 22, 2021 09:03
Copy link
Member

@katspaugh katspaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Dani!

@katspaugh katspaugh merged commit 97705a4 into l2-ux Sep 22, 2021
@katspaugh katspaugh deleted the feature/2619-chain-id-in-transaction-popups branch September 22, 2021 09:47
@github-actions github-actions bot locked and limited conversation to collaborators Sep 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[L2-UX] Indicate the chain in transaction popups
4 participants