Skip to content
This repository has been archived by the owner on Nov 10, 2023. It is now read-only.

v1 Display human readable names for "Known" addresses #1638

Closed
tschubotz opened this issue Nov 20, 2020 · 4 comments · Fixed by #2113
Closed

v1 Display human readable names for "Known" addresses #1638

tschubotz opened this issue Nov 20, 2020 · 4 comments · Fixed by #2113
Assignees
Labels
Feature 👑 New functionality

Comments

@tschubotz
Copy link
Member

tschubotz commented Nov 20, 2020

What is this feature about? (1 sentence)

This feature will display human readable when interacting with known contracts/protocols such as Uniswap or Compound.

Why is it needed? What is the value? For whom do we build it?

  • The top problem area that we identified is, that users don't know what they are signing and which protocols they are interacting with.
  • A first step in getting rid of cryptic addresses is displaying human readable names for known contracts.

High-level overview of the feature

Not in this version

Misc

@francovenica
Copy link
Contributor

I don't have access to the example list mentioned in the description.
Liliya shared with me this doc with some snapshots
https://docs.google.com/document/d/12ytKniMH1BpAn8Xqz2QOos2HhnY-JyH8MFA2N2R1d-Q/edit#

@tschubotz
Copy link
Member Author

@francovenica I granted access to you and everyone else. Also I updated the ticket description with all info docs we had more mobile with tech specs and design decisions.

cc @nicosampler

Let me know if this is sufficient so far or if we should do a session on the details of this ticket!

@nicosampler
Copy link
Contributor

I suggest we implement this feature in safe-react-components.

We already have the EthHashInfo component: https://safe-components.dev.gnosisdev.com/?path=/docs/ethereum-eth-hash-info--address that provides the Identicon, the address, and the action buttons.

As this feature is required by safe-react but can be also useful for safe-react-apps I think it's a good idea to fetch the gateway in this component and render the known address if there is a match directly in this component.

As a plus, in safe-react and all the safe-apps making use of this component will get this feature by only updating the safe-react-components version.

I would like to hear your opinions @dasanra @rmeissner @mikheevm

@nicosampler
Copy link
Contributor

This task will have two parts:

  • Edit EthHashInfo in SRC to support a custom icon.
  • In tx-list, when the CW returns to info or if the addressBook has info about it, it will be shown.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Feature 👑 New functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants