v2 Display human readable names for "Known" addresses

[tschubotz]

What is this feature about? (1 sentence)

This feature will display human readable when interacting with known contracts/protocols such as Uniswap or Compound.

Why is it needed? What is the value? For whom do we build it?

• The top problem area that we identified is, that users don't know what they are signing and which protocols they are interacting with.
• A first step in getting rid of cryptic addresses is displaying human readable names for known contracts.

High-level overview of the feature

• Refer to v1 (v1 Display human readable names for "Known" addresses #1638) for details – we missed the outgoing and incoming tx details – out of scope, moved to [Known Addresses] Display known address in the recipient field of the Send Funds form #2817

Implementation (added by @iamacook after discussion with @liliya-soroka )

Everything inside expanded transaction details regarding: safe creation, safe settings (transactions) and outgoing transactions requires known names added. Priority is given to address book entries, then known addresses returned by the /transactions endpoint.

Structs

• Safe creation - https://gnosis.github.io/safe-client-gateway/docs/models/service/transactions/struct.Creation.html
• Safe setting transactions - https://gnosis.github.io/safe-client-gateway/docs/models/service/transactions/enum.SettingsInfo.html
• Outgoing transactions - https://gnosis.github.io/safe-client-gateway/docs/models/service/transactions/struct.Transfer.html

Reference:

• Design Overview: https://docs.google.com/document/d/12ytKniMH1BpAn8Xqz2QOos2HhnY-JyH8MFA2N2R1d-Q/edit#heading=h.eq8eoqliqxlt
• Implementation: https://docs.google.com/document/d/1if8Sowyj1VhiVcRQojwmzMuDdo48dyndRBFrzIEa6zk/edit#heading=h.t0of4xmer2ue

Not in this version

• Known addresses in addresses in decoded data. This is part of v3.

Misc

• "press release": https://docs.google.com/document/d/11ABA0Nj9gQ_yyCTn-4vgNfJ5XqqputXENTNUcIe03E8/edit
• Mobile ticket: v2 Known Addresses safe#397
• v3: v3 Display human readable names for "Known" addresses #1867
• v1: v1 Display human readable names for "Known" addresses #1638
• client gateway:
  • SafeInfo endpoint in the gateway includingAddressInfo safe-client-gateway#242, Add KnownAddress for all addresses in the CreationTransaction safe-client-gateway#245

Implementation

• The known addresses come from backend
• AB priority
• Use the data in EthHashInfo

[tschubotz]

https://docs.google.com/document/d/1if8Sowyj1VhiVcRQojwmzMuDdo48dyndRBFrzIEa6zk/edit#

[liliya-soroka]

Missed in known addresses v1:

• The addresses are not taken from the known address list on transaction details. - Outgoing tx /Incoming txs.
  Only custom transaction was covered in known addresses v1

1.Try to send funds to any address from the known addresses list
2. open transaction details
Current result: The logo and name are not taken from the known address list.

• [ ]" send to " address on review of safe apps - the address should be recognised if it's in known address list or in addressbook
  

Please, include it into the known addresses v2

[katspaugh]

@liliya-soroka Outgoing Txns are out of scope for this ticket, it requires a separate endpoint that backend don't expose atm (thanks Aaron for checking).

Update: made a ticket for that, please see #2817

[liliya-soroka]

@iamacook and @francovenica . The feature is returned back to the sprint backlog.
It's expected that in v2 of "known addresses" support for safe settings txs( update mastercopy, enable/disable a module, change fallbackhandler and etc from mastercopy functions ) + safe creation txs will be added
For the details see specification - https://docs.google.com/document/d/1if8Sowyj1VhiVcRQojwmzMuDdo48dyndRBFrzIEa6zk/edit#

[iamacook]

@iamacook and @francovenica . The feature is returned back to the sprint backlog. It's expected that in v2 of "known addresses" support for safe settings txs( update mastercopy, enable/disable a module, change fallbackhandler and etc from mastercopy functions ) + safe creation txs will be added For the details see specification - https://docs.google.com/document/d/1if8Sowyj1VhiVcRQojwmzMuDdo48dyndRBFrzIEa6zk/edit#

There needs to be some adjustments in the backend to accomodate for these features and, as such, this ticket was split. Can you add your comments to the ticket @katspaugh added above instead? #2817 @liliya-soroka @francovenica

[francovenica]

Yes. I'll pass it. I don't see issues regarding owners adding/removing/replacing since I believe the objective of showing known addresses is for contracts to show their names and is not that important for regular wallet accounts that could be owners of a safe.