Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

feature: EthHashInfo add custom avatar #112

Merged
merged 4 commits into from
Mar 31, 2021
Merged

feature: EthHashInfo add custom avatar #112

merged 4 commits into from
Mar 31, 2021

Conversation

nicosampler
Copy link
Contributor

Needed it in 5afe/safe-react#1638.

@nicosampler nicosampler self-assigned this Mar 30, 2021
@github-actions
Copy link

github-actions bot commented Mar 30, 2021

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@ghost
Copy link

ghost commented Mar 30, 2021

Travis automatic deployment:
https://pr112--safereactcomponents.review.gnosisdev.com

@ghost
Copy link

ghost commented Mar 30, 2021

Travis automatic deployment:
https://pr112--safereactcomponents.review.gnosisdev.com

@ghost
Copy link

ghost commented Mar 30, 2021

Travis automatic deployment:
https://pr112--safereactcomponents.review.gnosisdev.com

Copy link
Contributor

@fernandomg fernandomg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still not convinced about the prop name, but it's ok. Can be changed in the future.

@dasanra
Copy link
Collaborator

dasanra commented Mar 31, 2021

The thing that screw me more here is the withAvatar prop, that can be used as a boolean to use Identicon or as a string to pass a link. But it's a weird use for a prop that can behave as a simple boolean or as a string parameter.

I would flag it as 2 separate props:

  • showAvatar that will show the Identicon avatar by default
  • customAvatar to pass the custom link

@fernandomg @nicosampler what do you think?

@nicosampler
Copy link
Contributor Author

I think that will be much clear, I was trying to use only one prop for everything. But You and Fer found that confusing, so your proposal makes sense to me.

@ghost
Copy link

ghost commented Mar 31, 2021

Travis automatic deployment:
https://pr112--safereactcomponents.review.gnosisdev.com

@nicosampler nicosampler merged commit 2e427ee into development Mar 31, 2021
@nicosampler nicosampler deleted the issue-1638 branch March 31, 2021 20:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants