Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

(Feature) - Refactor ethScan buttons usage #69

Merged
merged 8 commits into from
Oct 6, 2020

Conversation

Agupane
Copy link
Contributor

@Agupane Agupane commented Oct 1, 2020

Related to #1417

Description

This PR contains breaking changes, the users would need to change value and network with

const scanBlockUrl = () => ({
  alt: string,
  url: string,
});

For the EtherscanButton and for the EthHashInfo component:

  • showEtherscanBtn => should be replaced with showScanBlocksButton
  • network=> scanBlockUrl

EtherscanButton will be replaced with ExplorerButton

@Agupane Agupane requested a review from nicosampler October 1, 2020 13:17
@Agupane Agupane self-assigned this Oct 1, 2020
@github-actions
Copy link

github-actions bot commented Oct 1, 2020

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@ghost
Copy link

ghost commented Oct 1, 2020

Travis automatic deployment:
https://pr69--safereactcomponents.review.gnosisdev.com

@ghost
Copy link

ghost commented Oct 2, 2020

Travis automatic deployment:
https://pr69--safereactcomponents.review.gnosisdev.com

@Agupane
Copy link
Contributor Author

Agupane commented Oct 2, 2020

I think we should rename EtherscanButton with another name like ScanBlockButton or something like that, what do you think/suggest? @fernandomg @nicosampler

@nicosampler
Copy link
Contributor

I think we should rename EtherscanButton with another name like ScanBlockButton or something like that, what do you think/suggest? @fernandomg @nicosampler

explorerButton?

@ghost
Copy link

ghost commented Oct 6, 2020

Travis automatic deployment:
https://pr69--safereactcomponents.review.gnosisdev.com

@ghost
Copy link

ghost commented Oct 6, 2020

Travis automatic deployment:
https://pr69--safereactcomponents.review.gnosisdev.com

@ghost
Copy link

ghost commented Oct 6, 2020

Travis automatic deployment:
https://pr69--safereactcomponents.review.gnosisdev.com

1 similar comment
@ghost
Copy link

ghost commented Oct 6, 2020

Travis automatic deployment:
https://pr69--safereactcomponents.review.gnosisdev.com

@Agupane Agupane merged commit 70e57bd into development Oct 6, 2020
@Agupane Agupane deleted the ethScanButton-refactor branch October 6, 2020 15:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants