Skip to content
This repository has been archived by the owner on Nov 10, 2023. It is now read-only.

[xDai] - Parametrize Etherscan hardcoded values in favor of config-specified RPC #1417

Closed
fernandomg opened this issue Sep 29, 2020 · 0 comments
Assignees

Comments

@fernandomg
Copy link
Contributor

fernandomg commented Sep 29, 2020

The safe-react-component EthHashInfo has the Etherscan hardcoded.

One option is to add two optional parameters, url and alt, which we'll be able to replace the network functionality.
Another option is to refactor it and make it generic (that would require a new task in the safe-react-components repository).

Edit: Created separated issues for Contract Interaction and Transaction Builder

@Agupane Agupane self-assigned this Sep 30, 2020
Agupane added a commit that referenced this issue Oct 2, 2020
…parametrize-ethscan-values

# Conflicts:
#	src/config/networks/mainnet.ts
#	src/config/networks/network.d.ts
#	src/config/networks/rinkeby.ts
#	src/config/networks/xdai.ts
fernandomg added a commit that referenced this issue Oct 6, 2020
Agupane added a commit that referenced this issue Oct 6, 2020
…/gnosis/safe-react into feature/#1417-parametrize-ethscan-values

# Conflicts:
#	src/config/index.ts
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants