Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: support generate project with cmake 3.18 #1885

Merged
merged 2 commits into from
May 26, 2022

Conversation

aceforeverd
Copy link
Collaborator

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
  • What is the current behavior? (You can also link to an open issue here)

  • What is the new behavior (if this is a feature change)?

@github-actions github-actions bot added build openmldb compiling and installing execute-engine hybridse sql engine storage-engine openmldb storage engine. nameserver & tablet labels May 25, 2022
@aceforeverd aceforeverd added this to the v0.6 milestone May 25, 2022
@codecov
Copy link

codecov bot commented May 25, 2022

Codecov Report

Merging #1885 (5a8d3d4) into main (0b0d218) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #1885      +/-   ##
============================================
- Coverage     75.74%   75.70%   -0.04%     
  Complexity      347      347              
============================================
  Files           613      613              
  Lines        117018   117018              
  Branches       1024     1024              
============================================
- Hits          88631    88587      -44     
- Misses        28178    28222      +44     
  Partials        209      209              
Impacted Files Coverage Δ
src/sdk/db_sdk.cc 62.58% <0.00%> (-2.73%) ⬇️
src/catalog/tablet_catalog.cc 72.91% <0.00%> (-1.73%) ⬇️
src/storage/schema.h 89.43% <0.00%> (-1.63%) ⬇️
src/sdk/sql_cluster_router.cc 54.84% <0.00%> (-0.43%) ⬇️
src/client/tablet_client.cc 55.11% <0.00%> (-0.34%) ⬇️
src/tablet/tablet_impl.cc 59.34% <0.00%> (-0.30%) ⬇️
src/catalog/client_manager.cc 42.20% <0.00%> (-0.29%) ⬇️
src/storage/mem_table.cc 89.13% <0.00%> (-0.28%) ⬇️
src/zk/zk_client.cc 83.55% <0.00%> (-0.27%) ⬇️
hybridse/src/vm/runner.cc 67.76% <0.00%> (-0.12%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b0d218...5a8d3d4. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented May 25, 2022

Linux Test Report

       57 files       187 suites   1h 3m 18s ⏱️
  8 503 tests   8 499 ✔️ 4 💤 0
12 489 runs  12 485 ✔️ 4 💤 0

Results for commit 5a8d3d4.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

SDK Test Report

  75 files    75 suites   6m 11s ⏱️
163 tests 161 ✔️ 2 💤 0
204 runs  202 ✔️ 2 💤 0

Results for commit 5a8d3d4.

@github-actions
Copy link
Contributor

HybridSE Linux Test Report

       67 files       235 suites   6m 35s ⏱️
19 059 tests 19 057 ✔️ 2 💤 0

Results for commit 5a8d3d4.

@github-actions
Copy link
Contributor

HybridSE Mac Test Report

       67 files       235 suites   6m 33s ⏱️
19 059 tests 19 057 ✔️ 2 💤 0

Results for commit 5a8d3d4.

Copy link
Collaborator

@zhanghaohit zhanghaohit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@tobegit3hub tobegit3hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aceforeverd aceforeverd merged commit 555077f into 4paradigm:main May 26, 2022
@aceforeverd aceforeverd deleted the feat-1374-cmake branch May 26, 2022 10:40
@aceforeverd
Copy link
Collaborator Author

Bugs (0.5.x)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build openmldb compiling and installing execute-engine hybridse sql engine storage-engine openmldb storage engine. nameserver & tablet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cmake v3.18 support build(proto c): move openmldb generated proto cpp files into build directory
3 participants