Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(proto c): move openmldb generated proto cpp files into build directory #1091

Closed
aceforeverd opened this issue Jan 13, 2022 · 1 comment · Fixed by #1885
Closed

build(proto c): move openmldb generated proto cpp files into build directory #1091

aceforeverd opened this issue Jan 13, 2022 · 1 comment · Fixed by #1885
Assignees
@aceforeverd
Labels
enhancement New feature or request good first issue Good for newcomers storage-engine openmldb storage engine. nameserver & tablet

Comments

@aceforeverd
Copy link
Collaborator

OpenMLDB/src/CMakeLists.txt

Line 20 in 1e643c5

--cpp_out=${project_dir}/src/proto/

currently hybridse's proto gen cpp files were put in build directory, while openmldb's were in source tree.

To keep consistent, openmldb's proto gen files should output to build directory as well
@aceforeverd aceforeverd added the enhancement New feature or request label Jan 13, 2022
@aceforeverd aceforeverd added this to the v0.5 milestone Jan 13, 2022
@aceforeverd aceforeverd mentioned this issue Jan 13, 2022
Open
@aceforeverd

This comment was marked as off-topic.

Sign in to view
@aceforeverd aceforeverd self-assigned this Jan 25, 2022
@aceforeverd aceforeverd added the good first issue Good for newcomers label Feb 23, 2022
@lumianph lumianph mentioned this issue Feb 28, 2022
Closed
@aceforeverd aceforeverd removed this from the v0.5 milestone May 7, 2022
@aceforeverd aceforeverd added the storage-engine openmldb storage engine. nameserver & tablet label May 7, 2022
@lumianph lumianph mentioned this issue May 10, 2022
Closed
@Cupid0320 Cupid0320 mentioned this issue May 11, 2022
Open
aceforeverd added a commit to aceforeverd/fedb that referenced this issue May 25, 2022
@aceforeverd
fix(4paradigm#1091): move proto gen file into build/src/proto
5a8d3d4
@aceforeverd aceforeverd mentioned this issue May 25, 2022
Merged
aceforeverd added a commit that referenced this issue May 26, 2022
@aceforeverd
build: support generate project with cmake 3.18 (#1885)
555077f 
* fix(#1374): support build over cmake 3.18

* fix(#1091): move proto gen file into build/src/proto
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aceforeverd aceforeverd

Labels
enhancement New feature or request good first issue Good for newcomers storage-engine openmldb storage engine. nameserver & tablet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

build: support generate project with cmake 3.18 aceforeverd/fedb
1 participant
@aceforeverd