Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: don't read existing values when parsing without array repeat #37

Merged
merged 1 commit into from
Jun 23, 2024
Merged

perf: don't read existing values when parsing without array repeat #37

merged 1 commit into from
Jun 23, 2024

Conversation

PondWader
Copy link
Contributor

Reading values from an object is relatively expensive, this PR avoids reading a previous value in the current object unless arrayRepeat is set to true.

image

43081j
43081j approved these changes Jun 23, 2024
View reviewed changes
Copy link
Owner

@43081j 43081j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch!

you may have run it already but could you be sure to have run npm run format

i need to get it added to CI really as a check

@PondWader
Copy link
Contributor Author

I've run it already

@43081j 43081j merged commit b7a909e into 43081j:main Jun 23, 2024
3 checks passed
@PondWader PondWader deleted the optimize-disabled-array-repeat branch June 23, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@43081j 43081j 43081j approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PondWader @43081j