perf: don't read existing values when parsing without array repeat (#37)

43081j · Jun 23, 2024 · b7a909e · b7a909e
1 parent 036311a
commit b7a909e
Showing 1 changed file with 7 additions and 7 deletions.
diff --git a/src/parse.ts b/src/parse.ts
@@ -138,18 +138,18 @@ export function parse(input: string, options?: ParseOptions): ParsedQuery {
         }
 
         const newValue = valueDeserializer(value, currentKey);
-        const currentValue = currentObj[currentKey];
-
-        if (currentValue === undefined || !arrayRepeat) {
-          currentObj[currentKey] = newValue;
-        } else if (arrayRepeat) {
+        if (arrayRepeat) {
+          const currentValue = currentObj[currentKey];
+          if (currentValue === undefined) {
+            currentObj[currentKey] = newValue;
+          }
           // Optimization: value.pop is faster than Array.isArray(value)
-          if ((currentValue as unknown[]).pop) {
+          else if ((currentValue as unknown[]).pop) {
             (currentValue as unknown[]).push(newValue);
           } else {
             currentObj[currentKey] = [currentValue, newValue];
           }
-        }
+        } else currentObj[currentKey] = newValue;
       }
 
       // Reset reading key value pairs