-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Document where config comes from #350
Conversation
Commit to help start discussion
I've also opened yuvipanda/jupyterhub-configurator#8 to talk more about the configurator |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this a great start!
We can go from here in subsequent PRs if that is actually necessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, I approved more quickly than it should be.
I think there is a missing reference in the index.md, otherwise, I do not see this new page in the side column 😉
Because I noticed it is not actually ready
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me - just added a couple of links in there so people can click-through easily for reference.
Once this is linked in the toctree I think this is good to merge! (assuming it is factually correct and complete, I'll defer to @yuvipanda on that)
| Source | Maintainer | Notes | | ||
| - | - | - | | ||
| Upstream defaults from z2jh | z2jh maintainers | `hub-templates/base-hub/Chart.yaml` lists the z2jh version. Most of our configuration is directly from upstream | | ||
| `hub-templates/base-hub/values.yaml` | 2i2c engineers | Common to all hubs run from this repo | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| `hub-templates/base-hub/values.yaml` | 2i2c engineers | Common to all hubs run from this repo | | |
| [`hub-templates/base-hub/values.yaml`](https://github.com/2i2c-org/pilot-hubs/blob/master/hub-templates/base-hub/values.yaml) | 2i2c engineers | Common to all hubs run from this repo | |
| - | - | - | | ||
| Upstream defaults from z2jh | z2jh maintainers | `hub-templates/base-hub/Chart.yaml` lists the z2jh version. Most of our configuration is directly from upstream | | ||
| `hub-templates/base-hub/values.yaml` | 2i2c engineers | Common to all hubs run from this repo | | ||
| `deploy.py` | 2i2c engineers | Programmatic overrides for each type of hub, particularly around Auth0 integration | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| `deploy.py` | 2i2c engineers | Programmatic overrides for each type of hub, particularly around Auth0 integration | | |
| [`deploy.py`](https://github.com/2i2c-org/pilot-hubs/blob/master/deploy.py) | 2i2c engineers | Programmatic overrides for each type of hub, particularly around Auth0 integration | |
| Upstream defaults from z2jh | z2jh maintainers | `hub-templates/base-hub/Chart.yaml` lists the z2jh version. Most of our configuration is directly from upstream | | ||
| `hub-templates/base-hub/values.yaml` | 2i2c engineers | Common to all hubs run from this repo | | ||
| `deploy.py` | 2i2c engineers | Programmatic overrides for each type of hub, particularly around Auth0 integration | | ||
| `hubs.yaml` | 2i2c engineers | Specific to each hub | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| `hubs.yaml` | 2i2c engineers | Specific to each hub | | |
| [`hubs.yaml`](https://github.com/2i2c-org/pilot-hubs/blob/master/hubs.yaml) | 2i2c engineers | Specific to each hub | |
I've changed some of these locations in #352, so I've merged this PR into that. I've also addressed the missing toc link + markdown links there. Thanks @choldgraf and @damianavila |
Commit to help start discussion