[WIP] Document where config comes from #350
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit to help start discussion
8 tasks
|
I've also opened yuvipanda/jupyterhub-configurator#8 to talk more about the configurator |
damianavila
previously approved these changes
Apr 20, 2021
damianavila
reviewed
Apr 20, 2021
damianavila
dismissed
their stale review
Because I noticed it is not actually ready
choldgraf
reviewed
Apr 20, 2021
There was a problem hiding this comment.
This looks good to me - just added a couple of links in there so people can click-through easily for reference.
Once this is linked in the toctree I think this is good to merge! (assuming it is factually correct and complete, I'll defer to @yuvipanda on that)
| | Source | Maintainer | Notes | | ||
| | - | - | - | | ||
| | Upstream defaults from z2jh | z2jh maintainers | `hub-templates/base-hub/Chart.yaml` lists the z2jh version. Most of our configuration is directly from upstream | | ||
| | `hub-templates/base-hub/values.yaml` | 2i2c engineers | Common to all hubs run from this repo | |
There was a problem hiding this comment.
Suggested change
| | `hub-templates/base-hub/values.yaml` | 2i2c engineers | Common to all hubs run from this repo | | |
| | [`hub-templates/base-hub/values.yaml`](https://github.com/2i2c-org/pilot-hubs/blob/master/hub-templates/base-hub/values.yaml) | 2i2c engineers | Common to all hubs run from this repo | |
| | - | - | - | | ||
| | Upstream defaults from z2jh | z2jh maintainers | `hub-templates/base-hub/Chart.yaml` lists the z2jh version. Most of our configuration is directly from upstream | | ||
| | `hub-templates/base-hub/values.yaml` | 2i2c engineers | Common to all hubs run from this repo | | ||
| | `deploy.py` | 2i2c engineers | Programmatic overrides for each type of hub, particularly around Auth0 integration | |
There was a problem hiding this comment.
Suggested change
| | `deploy.py` | 2i2c engineers | Programmatic overrides for each type of hub, particularly around Auth0 integration | | |
| | [`deploy.py`](https://github.com/2i2c-org/pilot-hubs/blob/master/deploy.py) | 2i2c engineers | Programmatic overrides for each type of hub, particularly around Auth0 integration | |
| | Upstream defaults from z2jh | z2jh maintainers | `hub-templates/base-hub/Chart.yaml` lists the z2jh version. Most of our configuration is directly from upstream | | ||
| | `hub-templates/base-hub/values.yaml` | 2i2c engineers | Common to all hubs run from this repo | | ||
| | `deploy.py` | 2i2c engineers | Programmatic overrides for each type of hub, particularly around Auth0 integration | | ||
| | `hubs.yaml` | 2i2c engineers | Specific to each hub | |
There was a problem hiding this comment.
Suggested change
| | `hubs.yaml` | 2i2c engineers | Specific to each hub | | |
| | [`hubs.yaml`](https://github.com/2i2c-org/pilot-hubs/blob/master/hubs.yaml) | 2i2c engineers | Specific to each hub | |
|
I've changed some of these locations in #352, so I've merged this PR into that. I've also addressed the missing toc link + markdown links there. Thanks @choldgraf and @damianavila |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit to help start discussion