Master pr kz csv changes #6446
Master pr kz csv changes #6446
Conversation
|
@jamesaimonetti Think the build issue here is unrelated issue ? |
There was a problem hiding this comment.
The CI failure is related. pqc_cb_rates takes a list of 3 rate json objects and tries to create a CSV from them which is now mal-formed:
"_id","direction","prefix","pvt_type","rate_cost","ratedeck_id","routes"
"XX-1222","inbound","1222","rate","1.0","custom",""
"XX-1333","inbound","1333","rate","2.0","custom","^\+?1333.+$"
"XX-1444","inbound","1444","rate","3.0","custom","["^\\+?1444.+$"]"
You'll notice the last row's last column is unescaped quotes. This gets decoded on KAZOO's side to <<"[">> which is...not great...as a route regexp.
bradfordben
force-pushed
the
master-pr_kz_csv_changes
branch
from
6af02bd to
9e09185
Compare
|
@jamesaimonetti I have change things to always surround cells in double quotes and fixed the json to/from csv error so it should be good for a second look when you have a chance. |
bradfordben
force-pushed
the
master-pr_kz_csv_changes
branch
from
9e09185 to
aad737c
Compare
bradfordben
force-pushed
the
master-pr_kz_csv_changes
branch
from
aad737c to
cd4431a
Compare
|
Im not sure why make release failed, It looks like it hit a system error when trying to load a view from couch during account validation. Cant see why the CSV changes would have caused this. Is this an error pulled in from master? |
escaping of special charters
bradfordben
force-pushed
the
master-pr_kz_csv_changes
branch
from
cd4431a to
1e7b275
Compare
|
rebasing on master |
Standardized (with the lack of standards, https://tools.ietf.org/html/rfc4180) the creating and reading of CSV files and properly escaping characters. Prior to this, the CSV code could not handle escaped `,` correctly (Would replace them with `;`). This is needed for including JSON in CSV cells.
|
Merged, thanks! |
|
@jamesaimonetti Thanks for reviewing. Would you like me to backport this to 4.3 or not? |
Standardized (with the lack of standards, https://tools.ietf.org/html/rfc4180) the creating and reading of CSV files. Properly escaping charters.
We needed to be able to do this as the current csv code could not handle escaped
,correctly (Would replace them with;)This was needed for a kazoo tasks callflow module (separate pr to come)to allow the user to create a callflow with a dynamic
flowyou needed to be able to takeflowas an escaped json string.Example json data in a csv row would be
not json,"{""data"": { ""id"": ""2ab9ffb3bad31b8bb1d38eaf840f8dcc"", ""timeout"": 20, ""can_call_self"": false, ""delay"": 0, ""strategy"": ""simultaneous"" }, ""module"": ""user"", ""children"": {}}"