Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a disconnect method for the socket.io socket #44

Merged
merged 4 commits into from
May 23, 2021
Merged

Added a disconnect method for the socket.io socket #44

merged 4 commits into from
May 23, 2021

Conversation

1c3t3a
Copy link
Owner

@1c3t3a 1c3t3a commented May 22, 2021

The current implementation missed a disconnection ability for the socket.io socket, as mentioned in #43.

@codecov
Copy link

codecov bot commented May 22, 2021

Codecov Report

Merging #44 (9448467) into main (2b950b6) will decrease coverage by 0.32%.
The diff coverage is 72.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #44      +/-   ##
==========================================
- Coverage   87.73%   87.41%   -0.33%     
==========================================
  Files           9        9              
  Lines        1305     1327      +22     
==========================================
+ Hits         1145     1160      +15     
- Misses        160      167       +7     
Impacted Files Coverage Δ
src/socketio/transport.rs 73.64% <68.18%> (-0.78%) ⬇️
src/lib.rs 98.95% <100.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b950b6...9448467. Read the comment docs.

@1c3t3a 1c3t3a force-pushed the issue-43 branch 9 times, most recently from d632e95 to eba6d62 Compare May 23, 2021 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant