Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redo the codecov config as soon as tarpaulin is able to check the coverage on every line #45

Closed
1c3t3a opened this issue May 23, 2021 · 0 comments · Fixed by #273
Closed
Labels
on_hold Issues that are important in the future but can't be tackled right now

Comments

@1c3t3a
Copy link
Owner

1c3t3a commented May 23, 2021

Currently tarpaulin has some issues detecting dangling or formatted lines, see #351. This lead to some issues in #44 where the diff target was hit. I reconfigured the CI to shut up, but we should change it back as soon as tarpaulin is stable. The old config looked like this:

coverage: 
    status:
      project:
        default:        
          target: auto
          threshold: 2%
          paths:
             - "src"
         branches:
           - main
         if_ci_failed: ignore
         informational: false
         only_pulls: false
@1c3t3a 1c3t3a added the on_hold Issues that are important in the future but can't be tackled right now label May 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
on_hold Issues that are important in the future but can't be tackled right now
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant