Skip to content
This repository has been archived by the owner on Dec 20, 2023. It is now read-only.

Add heading links #351

Merged
merged 3 commits into from
Jan 30, 2023
Merged

Add heading links #351

merged 3 commits into from
Jan 30, 2023

Conversation

mgwalker
Copy link
Contributor

This PR adds heading links with client-side code. A # is appended to the end of the heading with a link to that heading. If the heading doesn't have an id, it is assigned one based on the slug of the heading text. The # is styled as a usa-link.

screenshot of a heading with a hashtag behind it. the hashtag is circled in orange with an arrow pointing to it.

This PR also removes the external link icon from footer links. Closes #339.

@mgwalker mgwalker mentioned this pull request Jan 27, 2023
3 tasks
Copy link
Contributor

@MelissaBraxton MelissaBraxton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MelissaBraxton MelissaBraxton merged commit 5198e0b into main Jan 30, 2023
@MelissaBraxton MelissaBraxton deleted the heading-links branch January 30, 2023 21:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add links to headings Don't put external link icons on links in the footer
2 participants