Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy RC 426 to Production #11416

Merged
merged 16 commits into from
Oct 29, 2024
Merged

Deploy RC 426 to Production #11416

merged 16 commits into from
Oct 29, 2024

Commits on Oct 24, 2024

  1. LG-14548 dw stale data check idp to analytics (#11386)

    * LG-14548: DW stale data check job
    
    changelog: Internal, Reporting, Set up DW Stale Data Check
    
    * brakeman fixes
    
    * linting
    
    * specs fixes
    
    * using transaction_with_timeout
    
    * job name change
    
    * job name change
    
    * removing private
    
    ---------
    
    Co-authored-by: Osman Latif <olatif@flexion.us>
    colter-nattrass and olatifflexion authored Oct 24, 2024
    Configuration menu
    Copy the full SHA
    0e2ecc8 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2024

  1. Ignore unknown authncontext (#11362) (#11396)

    changelog: User-Facing Improvements, Integration Experience, Allowing and ignoring unknown authn_context values
    Sgtpluck authored Oct 25, 2024
    Configuration menu
    Copy the full SHA
    eca5f8d View commit details
    Browse the repository at this point in the history
  2. LG-14591 Cancel enrollments with deactivated profiles in proofing job (

    …#11363)
    
    changelog: Internal, In-person proofing, Cancel enrollments with deactivated profiles during the proofing job
    
    Additional Work: Fix activate after passing in person profile method
    
    Update the profile activate_after_passing_in_person method to no longer
    nil out fields other than in_person_verification_pending_at before
    attempting to activate the profile. The previous implementation would
    allow profiles with deactivation reasons or with fraud pending reasons
    to be activated.
    shanechesnutt-ft authored Oct 25, 2024
    Configuration menu
    Copy the full SHA
    9986f9a View commit details
    Browse the repository at this point in the history
  3. Upgrade to good_job v4 (#11377)

    changelog: Internal, Maintenance, Upgrade to good_job v4
    mitchellhenke authored Oct 25, 2024
    Configuration menu
    Copy the full SHA
    e2bfded View commit details
    Browse the repository at this point in the history
  4. LG-14353 Re-label selected email session key (#11395)

    * changelog: Internal, tech debt, rename session key
    
    * update remaining keys
    kevinsmaster5 authored Oct 25, 2024
    Configuration menu
    Copy the full SHA
    3e0d513 View commit details
    Browse the repository at this point in the history
  5. Enable rubocop rule to disallow OpenStruct usage (#11397)

    * Enable rubocop rule to disallow OpenStruct usage
    
    changelog: Internal, Performance, Enable rubocop rule to disallow OpenStruct usage
    
    * Update spec/views/users/piv_cac_authentication_setup/new.html.erb_spec.rb
    
    Co-authored-by: Andrew Duthie <1779930+aduth@users.noreply.github.com>
    
    ---------
    
    Co-authored-by: Andrew Duthie <1779930+aduth@users.noreply.github.com>
    mitchellhenke and aduth authored Oct 25, 2024
    Configuration menu
    Copy the full SHA
    774fa2d View commit details
    Browse the repository at this point in the history
  6. Changing LOGIN_ENV to properly construct piv url (#11401)

    * changelog: Internal, CI, Changing LOGIN_ENV to match review app environment
    stephencshelton authored Oct 25, 2024
    Configuration menu
    Copy the full SHA
    e11ea7d View commit details
    Browse the repository at this point in the history
  7. LG-14641 | Update "letter on the way" screen (#11346)

    * LG-14651 | Update "letter on the way" screen
    
    changelog: User-Facing Improvements, GPO flow, UI tweaks
    n1zyy authored Oct 25, 2024
    Configuration menu
    Copy the full SHA
    0e2e6c5 View commit details
    Browse the repository at this point in the history
  8. LG-13006: remove instances of skip_doc_auth - step 4/6 (#11338)

    * feat: remove instances of skip_doc_auth
    
    * changelog: Internal, In-person proofing, remove old skip_doc_auth variable
    
    * feat: remove skip_doc_auth from hybrid handoff
    
    * feat: fix linting
    
    * feat: update selected_remote helper method
    
    * feat: add proper variables from session
    
    * feat: update new variable on the frontend
    
    * feat: lintfix
    
    * feat: more lintfixes
    
    * feat: remove skip_doc_auth_from_handoff in controller
    
    * feat: update checks for hybrid_handoff controller
    
    * feat: revert removal of skip_doc_auth from how to verify controller
    
    * feat: more updates to how_to_verify controller
    
    * feat: lintfix
    
    * feat: remove skipDocAuth from comment
    
    * feat: add back old var for 50/50 testing
    
    * feat: lintfix
    
    * feat: revert removal of skip_doc_auth
    
    * feat: updates to utilize skipDocAuth in flow along side skipDocAuthFromHowToVerify
    
    * feat: lint fix
    
    * feat: pull out space and line updates
    
    * fix: another whitespace fix
    
    * space fix
    
    * fix: another whitespace line fix
    
    * feat: sync up with git
    
    * lintfix
    
    * feat: lintfix
    KeithNava authored Oct 25, 2024
    Configuration menu
    Copy the full SHA
    d7777bf View commit details
    Browse the repository at this point in the history
  9. Refactor 2FA setup controller specs (#11399)

    * Refactor 2FA setup controller specs
    
    changelog: Internal, Automated Testing, Refactor 2FA setup controller specs
    
    * Switch from "should" to "expect" syntax for RSpec
    
    Consistency
    
    See: #11399 (comment)
    aduth authored Oct 25, 2024
    Configuration menu
    Copy the full SHA
    ad1e9f0 View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2024

  1. Add id_token_hint usage tracking (#11404)

    * changelog: Internal, Analytics, Add id_token_hint usage tracking
    Sgtpluck authored Oct 28, 2024
    Configuration menu
    Copy the full SHA
    5ebb98d View commit details
    Browse the repository at this point in the history
  2. LG-14642: Update design and copy of GPO 'letter on the way' email (#1…

    …1351)
    
    LG-14642: Update design and copy of GPO 'letter on the way' email
    
    **Why**
    
    - Align the 'letter requested' design and language with our current
      design requirements
    
    **How**
    
    - Rewrote the email template to utilize the new language and iconography.
    - The template handles more complexity -- if the ServiceProvider is absent or has incomplete
      configuration details, we account for that and either hide or modify certain
      instructions and the call-to-action. This business logic is stored in
      a new presenter (`Idv::ByMail::LetterRequestedPresenter`).
    - Replaced `user_mailer.letter_reminder.*` with new message properties under
      `user_mailer.verify_by_mail_letter_requested.*`
    - Updated the Rails mailer previewer to include a dummy ServiceProvider
      and User with a pending profile to reflect the new content.
    
    changelog: User-Facing Improvements, IdV notifications, Redesign verify-by-mail 'letter requested' email notification
    
    ---------
    
    Co-authored-by: Jonathan Hooper <jonathan.hooper@gsa.gov>
    lmgeorge and jmhooper authored Oct 28, 2024
    Configuration menu
    Copy the full SHA
    085a3f1 View commit details
    Browse the repository at this point in the history
  3. Delete deprecated code (#11403)

    * remove deprecated usps_unique_id method that is no longer needed for backward compatibility
    
    * Changelog: Internal, In-person proofing, remove deprecated method that is no longer needed for backwards compatibility
    
    * remove obsolete test
    eileen-nava authored Oct 28, 2024
    Configuration menu
    Copy the full SHA
    47960fe View commit details
    Browse the repository at this point in the history
  4. LG-11799: Remove same_address_as_id from analytics (#11400)

    * begin removing same_address_as_id from analytics
    
    * remove same_address_as_id from extra_analytics created in verify_info_concern
    
    * update analytics feature specs to match new expectations
    
    * Changelog: Internal, In-person Proofing, remove same_address_as_id from analytics
    
    * modify idv_result_to_form_response to avoid mutating result
    eileen-nava authored Oct 28, 2024
    Configuration menu
    Copy the full SHA
    cab363b View commit details
    Browse the repository at this point in the history
  5. Rename state id controller route after FSM step removal (#11379)

    * Rename route
    
    changelog: Internal, In-person proofing, rename state id controller routes
    jennyverdeyen authored Oct 28, 2024
    Configuration menu
    Copy the full SHA
    763c845 View commit details
    Browse the repository at this point in the history
  6. LG-14887: Log action name with reCAPTCHA assessment result received (#…

    …11407)
    
    * Log action name with reCAPTCHA assessment result received`
    
    changelog: Internal, Analytics, Log action name with reCAPTCHA assessment result received`
    
    * Add missing recaptcha_action spec assertions
    aduth authored Oct 28, 2024
    Configuration menu
    Copy the full SHA
    1e55a4b View commit details
    Browse the repository at this point in the history