-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deploy RC 426 to Production #11416
Merged
Merged
Deploy RC 426 to Production #11416
+1,739
−660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* LG-14548: DW stale data check job changelog: Internal, Reporting, Set up DW Stale Data Check * brakeman fixes * linting * specs fixes * using transaction_with_timeout * job name change * job name change * removing private --------- Co-authored-by: Osman Latif <olatif@flexion.us>
…#11363) changelog: Internal, In-person proofing, Cancel enrollments with deactivated profiles during the proofing job Additional Work: Fix activate after passing in person profile method Update the profile activate_after_passing_in_person method to no longer nil out fields other than in_person_verification_pending_at before attempting to activate the profile. The previous implementation would allow profiles with deactivation reasons or with fraud pending reasons to be activated.
changelog: Internal, Maintenance, Upgrade to good_job v4
* changelog: Internal, tech debt, rename session key * update remaining keys
* Enable rubocop rule to disallow OpenStruct usage changelog: Internal, Performance, Enable rubocop rule to disallow OpenStruct usage * Update spec/views/users/piv_cac_authentication_setup/new.html.erb_spec.rb Co-authored-by: Andrew Duthie <1779930+aduth@users.noreply.github.com> --------- Co-authored-by: Andrew Duthie <1779930+aduth@users.noreply.github.com>
* changelog: Internal, CI, Changing LOGIN_ENV to match review app environment
* LG-14651 | Update "letter on the way" screen changelog: User-Facing Improvements, GPO flow, UI tweaks
* feat: remove instances of skip_doc_auth * changelog: Internal, In-person proofing, remove old skip_doc_auth variable * feat: remove skip_doc_auth from hybrid handoff * feat: fix linting * feat: update selected_remote helper method * feat: add proper variables from session * feat: update new variable on the frontend * feat: lintfix * feat: more lintfixes * feat: remove skip_doc_auth_from_handoff in controller * feat: update checks for hybrid_handoff controller * feat: revert removal of skip_doc_auth from how to verify controller * feat: more updates to how_to_verify controller * feat: lintfix * feat: remove skipDocAuth from comment * feat: add back old var for 50/50 testing * feat: lintfix * feat: revert removal of skip_doc_auth * feat: updates to utilize skipDocAuth in flow along side skipDocAuthFromHowToVerify * feat: lint fix * feat: pull out space and line updates * fix: another whitespace fix * space fix * fix: another whitespace line fix * feat: sync up with git * lintfix * feat: lintfix
* Refactor 2FA setup controller specs changelog: Internal, Automated Testing, Refactor 2FA setup controller specs * Switch from "should" to "expect" syntax for RSpec Consistency See: #11399 (comment)
* changelog: Internal, Analytics, Add id_token_hint usage tracking
…1351) LG-14642: Update design and copy of GPO 'letter on the way' email **Why** - Align the 'letter requested' design and language with our current design requirements **How** - Rewrote the email template to utilize the new language and iconography. - The template handles more complexity -- if the ServiceProvider is absent or has incomplete configuration details, we account for that and either hide or modify certain instructions and the call-to-action. This business logic is stored in a new presenter (`Idv::ByMail::LetterRequestedPresenter`). - Replaced `user_mailer.letter_reminder.*` with new message properties under `user_mailer.verify_by_mail_letter_requested.*` - Updated the Rails mailer previewer to include a dummy ServiceProvider and User with a pending profile to reflect the new content. changelog: User-Facing Improvements, IdV notifications, Redesign verify-by-mail 'letter requested' email notification --------- Co-authored-by: Jonathan Hooper <jonathan.hooper@gsa.gov>
* remove deprecated usps_unique_id method that is no longer needed for backward compatibility * Changelog: Internal, In-person proofing, remove deprecated method that is no longer needed for backwards compatibility * remove obsolete test
* begin removing same_address_as_id from analytics * remove same_address_as_id from extra_analytics created in verify_info_concern * update analytics feature specs to match new expectations * Changelog: Internal, In-person Proofing, remove same_address_as_id from analytics * modify idv_result_to_form_response to avoid mutating result
* Rename route changelog: Internal, In-person proofing, rename state id controller routes
…11407) * Log action name with reCAPTCHA assessment result received` changelog: Internal, Analytics, Log action name with reCAPTCHA assessment result received` * Add missing recaptcha_action spec assertions
jmdembe
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User-Facing Improvements
Internal