Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy RC 426 to Production #11416

Merged
merged 16 commits into from
Oct 29, 2024
Merged

Deploy RC 426 to Production #11416

merged 16 commits into from
Oct 29, 2024

Conversation

solipet
Copy link
Contributor

@solipet solipet commented Oct 29, 2024

User-Facing Improvements

  • GPO flow: UI tweaks (#11346)
  • IdV notifications: Redesign verify-by-mail 'letter requested' email notification (#11351)
  • Integration Experience: Allowing and ignoring unknown authn_context values (#11362)

Internal

  • Analytics: Add id_token_hint usage tracking (#11404)
  • Analytics: Log action name with reCAPTCHA assessment result received (#11407)
  • Automated Testing: Refactor 2FA setup controller specs (#11399)
  • CI: Changing LOGIN_ENV to match review app environment (#11401)
  • In-person Proofing: Remove same_address_as_id from analytics (#11400)
  • In-person proofing: Remove old skip_doc_auth variable (#11338)
  • In-person proofing: Rename state id controller routes (#11379)
  • In-person proofing: Cancel enrollments with deactivated profiles during the proofing job (#11363)
  • In-person proofing: Remove deprecated method that is no longer needed for backwards compatibility (#11403)
  • Maintenance: Upgrade to good_job v4 (#11377)
  • Performance: Enable rubocop rule to disallow OpenStruct usage (#11397)
  • Reporting: Set up DataWarehouse Stale Data Check (#11386)
  • Tech debt: Rename session key (#11395)

colter-nattrass and others added 16 commits October 24, 2024 16:04
* LG-14548: DW stale data check job

changelog: Internal, Reporting, Set up DW Stale Data Check

* brakeman fixes

* linting

* specs fixes

* using transaction_with_timeout

* job name change

* job name change

* removing private

---------

Co-authored-by: Osman Latif <olatif@flexion.us>
changelog: User-Facing Improvements, Integration Experience, Allowing and ignoring unknown authn_context values
…#11363)

changelog: Internal, In-person proofing, Cancel enrollments with deactivated profiles during the proofing job

Additional Work: Fix activate after passing in person profile method

Update the profile activate_after_passing_in_person method to no longer
nil out fields other than in_person_verification_pending_at before
attempting to activate the profile. The previous implementation would
allow profiles with deactivation reasons or with fraud pending reasons
to be activated.
changelog: Internal, Maintenance, Upgrade to good_job v4
* changelog: Internal, tech debt, rename session key

* update remaining keys
* Enable rubocop rule to disallow OpenStruct usage

changelog: Internal, Performance, Enable rubocop rule to disallow OpenStruct usage

* Update spec/views/users/piv_cac_authentication_setup/new.html.erb_spec.rb

Co-authored-by: Andrew Duthie <1779930+aduth@users.noreply.github.com>

---------

Co-authored-by: Andrew Duthie <1779930+aduth@users.noreply.github.com>
* changelog: Internal, CI, Changing LOGIN_ENV to match review app environment
* LG-14651 | Update "letter on the way" screen

changelog: User-Facing Improvements, GPO flow, UI tweaks
* feat: remove instances of skip_doc_auth

* changelog: Internal, In-person proofing, remove old skip_doc_auth variable

* feat: remove skip_doc_auth from hybrid handoff

* feat: fix linting

* feat: update selected_remote helper method

* feat: add proper variables from session

* feat: update new variable on the frontend

* feat: lintfix

* feat: more lintfixes

* feat: remove skip_doc_auth_from_handoff in controller

* feat: update checks for hybrid_handoff controller

* feat: revert removal of skip_doc_auth from how to verify controller

* feat: more updates to how_to_verify controller

* feat: lintfix

* feat: remove skipDocAuth from comment

* feat: add back old var for 50/50 testing

* feat: lintfix

* feat: revert removal of skip_doc_auth

* feat: updates to utilize skipDocAuth in flow along side skipDocAuthFromHowToVerify

* feat: lint fix

* feat: pull out space and line updates

* fix: another whitespace fix

* space fix

* fix: another whitespace line fix

* feat: sync up with git

* lintfix

* feat: lintfix
* Refactor 2FA setup controller specs

changelog: Internal, Automated Testing, Refactor 2FA setup controller specs

* Switch from "should" to "expect" syntax for RSpec

Consistency

See: #11399 (comment)
* changelog: Internal, Analytics, Add id_token_hint usage tracking
…1351)

LG-14642: Update design and copy of GPO 'letter on the way' email

**Why**

- Align the 'letter requested' design and language with our current
  design requirements

**How**

- Rewrote the email template to utilize the new language and iconography.
- The template handles more complexity -- if the ServiceProvider is absent or has incomplete
  configuration details, we account for that and either hide or modify certain
  instructions and the call-to-action. This business logic is stored in
  a new presenter (`Idv::ByMail::LetterRequestedPresenter`).
- Replaced `user_mailer.letter_reminder.*` with new message properties under
  `user_mailer.verify_by_mail_letter_requested.*`
- Updated the Rails mailer previewer to include a dummy ServiceProvider
  and User with a pending profile to reflect the new content.

changelog: User-Facing Improvements, IdV notifications, Redesign verify-by-mail 'letter requested' email notification

---------

Co-authored-by: Jonathan Hooper <jonathan.hooper@gsa.gov>
* remove deprecated usps_unique_id method that is no longer needed for backward compatibility

* Changelog: Internal, In-person proofing, remove deprecated method that is no longer needed for backwards compatibility

* remove obsolete test
* begin removing same_address_as_id from analytics

* remove same_address_as_id from extra_analytics created in verify_info_concern

* update analytics feature specs to match new expectations

* Changelog: Internal, In-person Proofing, remove same_address_as_id from analytics

* modify idv_result_to_form_response to avoid mutating result
* Rename route

changelog: Internal, In-person proofing, rename state id controller routes
…11407)

* Log action name with reCAPTCHA assessment result received`

changelog: Internal, Analytics, Log action name with reCAPTCHA assessment result received`

* Add missing recaptcha_action spec assertions
@solipet solipet merged commit 34fe0d9 into stages/prod Oct 29, 2024
1 check passed
@solipet solipet deleted the stages/rc-2024-10-29 branch October 29, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.