Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LG-14497: LQA updates #11305

Merged
merged 4 commits into from
Oct 3, 2024
Merged

LG-14497: LQA updates #11305

merged 4 commits into from
Oct 3, 2024

Conversation

matthinz
Copy link
Member

@matthinz matthinz commented Oct 2, 2024

🎫 Ticket

Link to the relevant ticket:
LG-14497

🛠 Summary of changes

This PR contains a couple of updates identified by the LQA process:

  1. Translate "digit" as "chiffres" in French in address verification OTP messages
  2. Insert a missing full width comma in Simplified Chinese translation of the address verfication OTP message

There was a comma missing from the voice message used to communicate address verification OTPs.

Note that the character here is a full width comma (U+FF0C).
…o French and Simplified Chinese translations
@matthinz matthinz requested a review from a team October 2, 2024 19:48
@matthinz matthinz merged commit cca7669 into main Oct 3, 2024
2 checks passed
@matthinz matthinz deleted the matthinz/14497-lqa-updates branch October 3, 2024 17:33
colter-nattrass pushed a commit that referenced this pull request Oct 23, 2024
* Translate "digit" as "chiffres" in French

* Add comma to Simplified Chinese translation

There was a comma missing from the voice message used to communicate address verification OTPs.

Note that the character here is a full width comma (U+FF0C).

* changelog: User-Facing Improvements, Identity verification, Updates to French and Simplified Chinese translations

* Remove telephony.format_type.digit from ALLOWED_UNTRANSLATED_KEYS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants